Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 9 Mar 2013 22:06:06 +0000
From:      Chris Rees <crees@FreeBSD.org>
To:        Eitan Adler <eadler@freebsd.org>
Cc:        svn-ports-head@freebsd.org, Baptiste Daroussin <bapt@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, Bryan Drewery <bdrewery@freebsd.org>
Subject:   Re: svn commit: r313742 - head/Mk
Message-ID:  <CADLo83_FR%2B3ZsoCGixxm=%2B-MUu1WfS2JO609F8_1Qe23dYmKGQ@mail.gmail.com>
In-Reply-To: <CAF6rxgm3cSXH9C4Yjsno8Z1Xn=YS29KFw=VeoJecg=UUpkgRgA@mail.gmail.com>
References:  <201303091837.r29IbppA061926@svn.freebsd.org> <20130309193923.GT18971@ithaqua.etoilebsd.net> <513BA899.4080205@FreeBSD.org> <20130309213647.GV18971@ithaqua.etoilebsd.net> <CAF6rxgm3cSXH9C4Yjsno8Z1Xn=YS29KFw=VeoJecg=UUpkgRgA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 9 March 2013 21:37, Eitan Adler <eadler@freebsd.org> wrote:
> On 9 March 2013 16:36, Baptiste Daroussin <bapt@freebsd.org> wrote:
>> On Sat, Mar 09, 2013 at 03:24:41PM -0600, Bryan Drewery wrote:
>>> On 3/9/2013 1:39 PM, Baptiste Daroussin wrote:
>>> > On Sat, Mar 09, 2013 at 06:37:51PM +0000, Chris Rees wrote:
>>> >> Author: crees
>>> >> Date: Sat Mar  9 18:37:51 2013
>>> >> New Revision: 313742
>>> >> URL: http://svnweb.freebsd.org/changeset/ports/313742
>>> >>
>>> >> Log:
>>> >>   Add NFS comment.
>>> >>
>>> >>   While here, escape single quote to stop confusing vim's syntax highlighting.
>>> >
>>> > That is wrong, because the escape appears in make showconfig as well as in the
>>> > dialog UI which is ugly. The best would be to fix the vim's syntax, can you
>>> > revert this change?
>>>
>>>
>>> This method seems to work in showconfig/config and vim:
>>>
>>> -APE_DESC?=             Monkey\'s Audio lossless format
>>> +APE_DESC?=             Monkey's Audio lossless format #'
>>>
>> Clever :)
>
> This still seems odd, and I would rather not see this in the Makefile.
>

I'm really sorry about this-- I've just reverted it.

I did have a quick look through the logs for that file, because I had
a sneaking suspicion about it; evidently I missed something.

Hopefully the log message I left this time is more easily greppable;
thanks for the pointer.

I'll look at fixing the Vim highlighting, but I don't know if it'll be
possible here-- I'll just have to get over it :)

Chris



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo83_FR%2B3ZsoCGixxm=%2B-MUu1WfS2JO609F8_1Qe23dYmKGQ>