Date: Tue, 03 Jan 2017 08:52:03 -0700 From: Ian Lepore <ian@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com>, Pedro Giffuni <pfg@FreeBSD.org> Cc: Conrad Meyer <cem@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r311109 - head/usr.bin/patch Message-ID: <1483458723.16152.107.camel@freebsd.org> In-Reply-To: <20170103102622.GO1923@kib.kiev.ua> References: <201701021823.v02INWXc028047@repo.freebsd.org> <CAG6CVpUUFoTZBO0Ja2aSn%2BeMi_BO0u131YKQ1yQumu%2BdRhVY3A@mail.gmail.com> <aa9172cb-cb95-36cf-c21d-48f8a7450ad5@FreeBSD.org> <CAG6CVpV7=Dx6VywV0MRY7z7LMwQrBcb-1qUhjngxjFsSZZHvHg@mail.gmail.com> <9c3fc378-ee5e-19ba-c286-1440d4b13615@FreeBSD.org> <20170103102622.GO1923@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2017-01-03 at 12:26 +0200, Konstantin Belousov wrote: > On Mon, Jan 02, 2017 at 07:41:26PM -0500, Pedro Giffuni wrote: > > > > > > > > On 01/02/17 17:54, Conrad Meyer wrote: > > > > > > I was suggesting using UINT32_MAX/2 on all platforms (which is > > > safe > > > everywhere). > > > > > Ah OK. INT_MAX is ~ (UINT_MAX / 2) so it's the same to use either. > > I just think it's clearer to use INT_MAX and the corresponding int > > type. > > > > The other issue is if diff(1) can handle such lines(?). > Of course it cannot, on ILP32 arches. > I kind of don't understand the premise of the naysayers in this thread. Some machines cannot do lines that are UINT_MAX long, so in that case we should not support any lines longer than USHORT_MAX? As if there aren't *billions* of line length limits to choose from between those two numbers? I'm also trying to picture the real-world need to diff and patch lines of ascii text longer than 64K, but for every problem out there, there is someone with a perverse need to solve that problem outside of the normal lines we all live between. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1483458723.16152.107.camel>