Date: Thu, 29 Aug 2019 19:27:01 -0400 From: Ed Maste <emaste@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: FreeBSD Hackers <freebsd-hackers@freebsd.org>, fcp@freebsd.org Subject: Re: FCP 20190401-ci_policy: CI policy Message-ID: <CAPyFy2BH2EN-KCWhtNku8BghnguEVXr=F04=H51_YdPCNPnhUA@mail.gmail.com> In-Reply-To: <CANCZdfqagrUzv5wOawypu55Naxt9%2BAHLSege4ccEzrDkuFa9Mg@mail.gmail.com> References: <CAOfEmZgEbT7ni80vWehHm%2B4oPyH3m%2Brb0M_VyxHmNM3rkhyG1Q@mail.gmail.com> <201908291905.x7TJ5Bw8091371@gndrsh.dnsmgr.net> <CANCZdfoYNn9Xcyds_YbDXMLTrMdmTewvP_pK7FSDAPbDAeV6Lw@mail.gmail.com> <CANCZdfqagrUzv5wOawypu55Naxt9%2BAHLSege4ccEzrDkuFa9Mg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 29 Aug 2019 at 17:32, Warner Losh <imp@bsdimp.com> wrote: > > In the past, if someone had any follow on work at all in their tree, the > reversion would be quite disruptive to that work. This sounds more like a problem with the tooling than an argument against reverting though. I agree that in the case where the fix is straightforward it's sensible, and in line with community norms, to just commit it. But in the case that a regression was introduced by a committed change, modern tools facilitate reverting and replaying changes without a lot of effort. > things quickly, imho, to hesitate a little on the revert. Especailly when > the broken thing is the playstation loader on powerpc that can stay broken > for the hour or six (or even days) it takes me to figure out why it > broke... Often things away from the beaten path don't get discovered for > days or weeks or months, and a reversion then can be extremely disruptive > if there's other changes layered on top of the offending commit.... Note that this isn't at all the issue under discussion in the FCP, which refers to issues that have already been detected by CI. For example, a commit which means amd64 panics on boot. Reverting quickly is a benefit in this sort of case found by CI precisely so that we don't end up with other changes on top that are difficult to unwind.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2BH2EN-KCWhtNku8BghnguEVXr=F04=H51_YdPCNPnhUA>