Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 4 Sep 2015 15:32:45 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Dirk Meyer <dirk.meyer@dinoex.sub.org>
Cc:        svn-ports-all@freebsd.org
Subject:   Re: svn commit: r395527 - in head/graphics/jasper: . files
Message-ID:  <20150904153245.GA3009@FreeBSD.org>
In-Reply-To: <0OhphfKmbi@dmeyer.dinoex.sub.org>
References:  <QesEk0/mjx@dmeyer.dinoex.sub.org> <xtBletsm0A@dmeyer.dinoex.sub.org> <201508290619.t7T6Js6d029551@repo.freebsd.org> <201508290619.t7T6Js6d029551@repo.freebsd.org> <20150829081543.GA8460@FreeBSD.org> <xtBletsm0A@dmeyer.dinoex.sub.org> <20150831062246.GA49457@FreeBSD.org> <QesEk0/mjx@dmeyer.dinoex.sub.org> <20150904075918.GA30044@FreeBSD.org> <0OhphfKmbi@dmeyer.dinoex.sub.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 04, 2015 at 04:29:10PM +0200, Dirk Meyer wrote:
> > That's exactly what I'm talking about: for everyone except you, it looks
> > wrong.  People will keep fixing it.
> > 
> > > I am also against sorting the Makefile lines by aplhabet.
> > > $ sort Makefile | less
> > 
> > I don't think anyone would even momentariry consider doing this.  Why do
> > you mention this idiocy?
> 
> because I see no benefit in sorting by alphabet Mailefile lines, and
> neither in sorting by alphabet USES= args.  It is the same, it hides
> functional ordering.

It's ridiculous to compare sorting of USES to sorting of Makefile lines.
In fact, USES do not imply any order, functional, sequential, or other.
It is just a list of *.mk files to be picked up from Mk/Uses.  If anyone
relies on some specific order of those values they can be in big trouble.

In make(1) world, the only correct way to establish operation order is
by correctly and unambiguously defining targets' dependencies.  As long
as they're correct and coherent, actual order in USES does not matter,
and it's just easier to maintain when it's sorted alphabetically.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150904153245.GA3009>