Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 31 Dec 2001 00:53:10 -0500
From:      Alan Eldridge <alane@geeksrus.net>
To:        Pete Fritchman <petef@databits.net>
Cc:        ports@FreeBSD.org
Subject:   Re: ports/33360: maintainer update: devel/py-optik: fix "make package" failure
Message-ID:  <20011231055310.GA45888@wwweasel.geeksrus.net>
In-Reply-To: <20011231001824.A42560@databits.net>
References:  <200112310450.fBV4o2w01101@freefall.freebsd.org> <20011231050114.GA30359@wwweasel.geeksrus.net> <20011231001824.A42560@databits.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Dec 31, 2001 at 12:18:24AM -0500, Pete Fritchman wrote:
>++ 31/12/01 00:01 -0500 - Alan Eldridge:
>| On Sun, Dec 30, 2001 at 08:50:02PM -0800, Ying-Chieh Liao wrote:
>| > >  .if !defined(NOPORTDOCS)
>| > > +DOCSDIR=${PREFIX}/share/doc/${PKGNAMEPREFIX}${PORTNAME}
>| > 
>| > maybe we have to make it general in bsd.port.mk ?
>| 
>| How 'bout we replace the current:
>| 
>| DOCSDIR?=${PREFIX}/share/doc/${PORTNAME}
>| 
>| with:
>| 
>| DOCSDIR?=${PREFIX}/share/doc/${PKGNAMEPREFIX}${PORTNAME}${PKGNAMESUFFIX}
>| 
>| Seems reasonable to me. 
>| 
>| So, what'll get broken if we do it?
>
>Every port that defines PKGNAME{PRE,SUF}FIX and uses DOCSDIR :)
>
>(think pkg-plist)

Kind of a strange "fix", really, in that it breaks everything it is supposed
to benefit... 

find $PORTSDIR -name Makefile | xargs grep -l DOCSDIR \
  | xargs egrep -l 'PKGNAME(PRE|SUFF)IX' | wc -l

And that would be 38 of them, 11 of which define their own DOCSDIR, so
they're safe. 

So that means we're only making a difference to 27 ports out of 6000+.

OK, move along, nothing to see here ....

-- 
Alan Eldridge
Pmmfmffmmfmp mmmpppppffmpmfpmpppff $PffMmmPppMpmPpfPpm mfpmmmmmfpmpmpppff.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011231055310.GA45888>