Date: Sun, 31 Dec 2006 19:47:04 +0100 From: Pav Lucistnik <pav@FreeBSD.org> To: Alejandro Pulver <alepulver@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/Mk bsd.wx.mk Message-ID: <1167590824.1320.52.camel@ikaros.oook.cz> In-Reply-To: <20061231150344.25871955@phobos.mars.bsd> References: <200612310434.kBV4YRXS037540@repoman.freebsd.org> <1167575429.1320.24.camel@ikaros.oook.cz> <20061231133753.4156b868@phobos.mars.bsd> <1167584645.1320.33.camel@ikaros.oook.cz> <20061231150344.25871955@phobos.mars.bsd>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-Iqo+IL/0aR5h2/EKKRU/
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: quoted-printable
Alejandro Pulver p=ED=B9e v ne 31. 12. 2006 v 15:03 -0300:
> On Sun, 31 Dec 2006 18:04:05 +0100
> Pav Lucistnik <pav@FreeBSD.org> wrote:
>=20
> > Alejandro Pulver p=ED=B9e v ne 31. 12. 2006 v 13:37 -0300:
> > > On Sun, 31 Dec 2006 15:30:29 +0100
> > > Pav Lucistnik <pav@FreeBSD.org> wrote:
> > >=20
> > > > > - Remove _WX_ILLEGAL_VERS_* added in the last update to 2.8. Th=
e reason is
> > > > > that each port should choose the version it can use, that inc=
ludes taking
> > > > > into account available components (also this brings much more=
chicken and
> > > > > egg problems so the code could get really messy).
> > > >=20
> > > > I have reverted this. It's needed as long as you want to let people=
use
> > > > ranges like 2.4+ together with python component, etc.
> > > >=20
> > >=20
> > > It is complex to do that (if you want to do it the right way), becaus=
e
> > > you need to parse components and dependencies before selecting a
> > > version. The current code is wrong since it will only reject componen=
ts
> > > without dependency type specifications (and if there were dependencie=
s
> > > then it will also ignore them).
> > >=20
> > > I think people should select the versions that actually work with the
> > > port, that's why the version specification string is so flexible.
> > >=20
> > > Also, if versions with invalid components are removed then the report=
ed
> > > error if a user writes USE_WX=3D2.4 and WX_COMPS=3Dsvg would be "sele=
cted a
> > > null or invalid WxWidgets version" instead of "selected a WxWidgets
> > > component (${_WX_COMP}) which is not available for the selected versi=
on
> > > (${_WX_VER})".
> >=20
> > That can be done, I'm confident.
> >=20
>=20
> Yes, but it will remove flexibility in some way:
>=20
> Currently the version is processed independently from the components.
> The first one is done in <bsd.port.post.mk> or in <bsd.port.pre.mk> if
> WX_PREMK is defined (for ports like "x11-toolkits/py-wxPython26"). And
> the second one is always checked in <bsd.port.post.mk>.
>=20
> If I make the version to depend on the components, then when USE_PREMK
> is defined, the port won't be able to modify WX_COMPS after
> <bsd.port.pre.mk> (because the components can alter the version, and if
> then the port will think it's using one, but other will be used).
Is this the problem with upcoming rollout of bsd.options.mk ?
I mean, do you need to change WX_COMPS after bsd.port.pre.mk except when
handling OPTIONS and WITH_* flags?
> > > > Also, the auto-detection does not seem to work:
> > > >=20
> [...]
> > >=20
> > > Sorry, I re-wrote it many times and forgot this:
> > >=20
> > > -_WX_VER_INSTALLED:=3D ${_HAVE_WX}
> > > +_WX_VER_INSTALLED:=3D ${_HAVE_WX:Mwx-*:S/wx-//}
> >=20
> > Please commit this fix.
> >=20
>=20
> Done.
Thanks!
--=20
Pav Lucistnik <pav@oook.cz>
<pav@FreeBSD.org>
I want to earn the right to be obnoxious before I'm too bitter to really
enjoy it.
-- Able
--=-Iqo+IL/0aR5h2/EKKRU/
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?=
=?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?=
=?ISO-8859-1?Q?_zpr=E1vy?=
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (FreeBSD)
iD8DBQBFmAWontdYP8FOsoIRAgxQAKCCEn0cQ+6OGwnypTJ/c79JVcDuuQCaA1cE
IbPINxY+ca7CGaJJ9FZu5dE=
=scve
-----END PGP SIGNATURE-----
--=-Iqo+IL/0aR5h2/EKKRU/--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1167590824.1320.52.camel>