Date: Mon, 04 Aug 1997 09:51:51 +0200 From: Poul-Henning Kamp <phk@dk.tfs.com> To: dg@root.com Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/ufs/ffs ffs_alloc.c Message-ID: <14326.870681111@critter.dk.tfs.com> In-Reply-To: Your message of "Mon, 04 Aug 1997 00:41:38 PDT." <199708040741.AAA08057@implode.root.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <199708040741.AAA08057@implode.root.com>, David Greenman writes: >>phk 1997/08/04 00:30:45 PDT >> >> Modified files: >> sys/ufs/ffs ffs_alloc.c >> Log: >> We got a couple of "map mismatch" panics from the following >> code. According to the crash dump, bpref is set to 445 >> and cgp->cg_nclusterblks is 444. Hence in the for loop, >> the test fails immediately but the following failure check >> (got == cgp->cg_nclusterblks) doesn't trigger because got > >> cgp->cg_nclusterblks. This wreaks havoc in the code after that. >> >> Fix: Move one source bit to the left :-) >> >> Noticed by: Mike Hibler <mike@fast.cs.utah.edu> >> Submitted by: Kirk McKusick <mckusick@McKusick.COM> > > Just so people aren't confused: the above patch has no affect on FreeBSD; >it's in an area of code that isn't even compiled. > >-DG > >David Greenman >Core-team/Principal Architect, The FreeBSD Project True, should have said that. This commit is just to keep us in sync with Kirk. -- Poul-Henning Kamp | phk@FreeBSD.ORG FreeBSD Core-team. http://www.freebsd.org/~phk | phk@login.dknet.dk Private mailbox. whois: [PHK] | phk@tfs.com TRW Financial Systems, Inc. Power and ignorance is a disgusting cocktail.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?14326.870681111>