Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 30 Oct 2013 09:57:07 -0500
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        Matthias Andree <mandree@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, owner-ports-committers@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r331435 - head/news/newsstar
Message-ID:  <49cc5ad931cc4f73c567e502c9601d63@shatow.net>
In-Reply-To: <201310232217.r9NMHonG071871@svn.freebsd.org>
References:  <201310232217.r9NMHonG071871@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2013-10-23 17:17, Matthias Andree wrote:
> Author: mandree
> Date: Wed Oct 23 22:17:50 2013
> New Revision: 331435
> URL: http://svnweb.freebsd.org/changeset/ports/331435
> 
> Log:
>   Support staging.
>   Reorder Makefile targets (post-install after post-patch).
>   Update to new LIB_DEPENDS format.
>   Disable chown, and leave that to the package.
> 
>   Note that this apparently exposes issues with
>   poudriere testport/make check-orphans due to absolute /var paths.
> 
> Modified:
>   head/news/newsstar/Makefile
>   head/news/newsstar/pkg-plist   (contents, props changed)
> 
> Modified: head/news/newsstar/Makefile
> ==============================================================================
> --- head/news/newsstar/Makefile	Wed Oct 23 22:15:15 2013	(r331434)
> +++ head/news/newsstar/Makefile	Wed Oct 23 22:17:50 2013	(r331435)
> @@ -11,7 +11,7 @@ COMMENT=	Transfer news between a local N
> 
>  LICENSE=	GPLv3
> 
> -LIB_DEPENDS=	gdbm:${PORTSDIR}/databases/gdbm
> +LIB_DEPENDS=	libgdbm.so:${PORTSDIR}/databases/gdbm
>  BUILD_DEPENDS=	xmlto:${PORTSDIR}/textproc/xmlto \
> 
> 		${LOCALBASE}/share/xml/docbook/4.5/docbookx.dtd:${PORTSDIR}/textproc/docbook-xml
> 
> @@ -22,6 +22,7 @@ OPTIONS_DEFINE=		SSL
>  OPTIONS_DEFAULT=	SSL
> 
>  CONFIGURE_ARGS+=--prefix=${PREFIX} \
> +		--disable-chown \
>  		--with-conf-dir=${PREFIX}/etc/newsstar \
>  		--with-rc-dir=/var/spool/newsstar/lib \
>  		--with-incoming-dir=/var/spool/newsstar/incoming
> @@ -29,7 +30,6 @@ CONFIGURE_ARGS+=--prefix=${PREFIX} \
>  CONFIGURE_ENV=	LIBS="-L${LOCALBASE}/lib ${ICONV_LIB}"
>  CPPFLAGS+=	-I${LOCALBASE}/include
> 
> -NO_STAGE=	yes
>  .include <bsd.port.options.mk>
> 
>  .if ! ${PORT_OPTIONS:MDOCS}
> @@ -69,29 +69,26 @@ DOCS=		AUTHORS INSTALL NEWS README TODO
>  EX_CONFIGS=	cf.server.sample curses.cf.sample filter.pl.sample 
> main.cf.sample \
>  		master.ignore.sample master.score.sample newsrc.sample
> 
> -pre-install:
> -	${MKDIR} ${PREFIX}/lib/${PORTNAME}

You lost this line. The dir never gets created now.

..

> Modified: head/news/newsstar/pkg-plist
..
> +@dirrmtry lib/newsstar


And now it fails to package with pkgng because the directory listed in 
plist doesn't really exist.

pkg-static: 
lstat(/wrkdirs/usr/ports/news/newsstar/work/stage/usr/local/lib/newsstar/): No such file or directory
pkg-static: DEVELOPER_MODE: Plist error: @dirrm lib/newsstar

-- 
Regards,
Bryan Drewery



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49cc5ad931cc4f73c567e502c9601d63>