Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 26 Mar 2002 22:18:17 +0200
From:      keramida@freebsd.org
To:        Gregory Neil Shapiro <gshapiro@freebsd.org>
Cc:        freebsd-current@freebsd.org, freebsd-stable@freebsd.org
Subject:   Re: For review: Revised sendmail startup settings
Message-ID:  <20020326201817.GB17467@hades.hell.gr>
In-Reply-To: <15520.10783.995435.407285@horsey.gshapiro.net>
References:  <15520.10783.995435.407285@horsey.gshapiro.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2002-03-25 23:58, Gregory Neil Shapiro wrote:
>
> FreeBSD 4.5-STABLE:	http://people.freebsd.org/~gshapiro/smstart-STABLE
> FreeBSD 5.0-CURRENT:	http://people.freebsd.org/~gshapiro/smstart-CURRENT

I don't have STABLE around, so I've only looked at smstart-CURRENT.
It's nice, if you ask me.

	--- etc/defaults/rc.conf	12 Mar 2002 21:47:31 -0000	1.140
	+++ etc/defaults/rc.conf	26 Mar 2002 07:31:02 -0000

	+			# If sendmail_enable=NO, then try:
	...
	+			# Else if sendmail_submit_enable=NO, then try:
	...
	+			# Endif

If you ask me, these If/Else/Endif comments are not really necessary.
As long as the relationship and dependencies of the various
sendmail_xxx_enable flags is clearly explained in rc.conf.5, there is no
need to duplicate the documentation in comments within rc.conf, IMHO.

	--- etc/defaults/rc.conf	12 Mar 2002 21:47:31 -0000	1.140
	+++ etc/defaults/rc.conf	26 Mar 2002 07:31:02 -0000

	-				# Flags for localhost-only MTA
	+				# Flags for sendmail_msp_queue daemon.

Good one!
By all means make this change, regardless of what you do with the rest.

I am not sure if duplicating the code of etc/rc in etc/mail/Makefile is
something I am really happy about though.  This means that anyone who wants
to make changes to etc/rc should remember to update etc/mail/Makefile too.

Giorgos Keramidas                       FreeBSD Documentation Project
keramida@{freebsd.org,ceid.upatras.gr}  http://www.FreeBSD.org/docproj/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020326201817.GB17467>