Date: Wed, 20 Jan 1999 15:30:48 -0800 (PST) From: gelderen@mediaport.org To: freebsd-gnats-submit@FreeBSD.ORG Subject: kern/9590: Clean up for -Wall warnings Message-ID: <199901202330.PAA02731@hub.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 9590
>Category: kern
>Synopsis: Clean up for -Wall warnings
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Jan 20 15:40:03 PST 1999
>Closed-Date:
>Last-Modified:
>Originator: Jeroen C. van Gelderen
>Release: 3.0-CURRENT
>Organization:
>Environment:
n/a
>Description:
Patches to imgact-elf.c to eliminate -Wall warnings. Comments on style are requested before I start doing the rest of the files...
>How-To-Repeat:
>Fix:
Index: imgact_elf.c
===================================================================
RCS file: /cvs/src/sys/kern/imgact_elf.c,v
retrieving revision 1.44
diff -r1.44 imgact_elf.c
310,311c310,312
<
< if (error = namei(&nd)) {
---
>
> error = namei(&nd);
> if (error) {
333c334,335
< if (error = elf_check_header(hdr, ET_DYN))
---
> error = elf_check_header(hdr, ET_DYN);
> if (error)
355c357
< if (error = elf_load_section(p, vmspace, nd.ni_vp,
---
> error = elf_load_section(p, vmspace, nd.ni_vp,
360c362,363
< phdr[i].p_filesz, prot))
---
> phdr[i].p_filesz, prot);
> if (error)
434c437,438
< if (error = exec_extract_strings(imgp))
---
> error = exec_extract_strings(imgp);
> if (error)
453,458c457,463
< if (error = elf_load_section(imgp->proc,
< vmspace, imgp->vp,
< phdr[i].p_offset,
< (caddr_t)phdr[i].p_vaddr,
< phdr[i].p_memsz,
< phdr[i].p_filesz, prot))
---
> error = elf_load_section(imgp->proc,
> vmspace, imgp->vp,
> phdr[i].p_offset,
> (caddr_t)phdr[i].p_vaddr,
> phdr[i].p_memsz,
> phdr[i].p_filesz, prot);
> if (error)
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199901202330.PAA02731>