Date: Tue, 24 Jul 2007 19:21:09 +0100 (BST) From: Robert Watson <rwatson@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: arch@freebsd.org, gnn@freebsd.org, bz@freebsd.org, current@freebsd.og, freebsd-arch@freebsd.org Subject: Re: Removing NET_NEEDS_GIANT: first patch Message-ID: <20070724192023.N15979@fledge.watson.org> In-Reply-To: <200707241107.43047.jhb@freebsd.org> References: <20070724110908.T83919@fledge.watson.org> <200707241107.43047.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 24 Jul 2007, John Baldwin wrote: > On Tuesday 24 July 2007 06:17:45 am Robert Watson wrote: >> Patch attached, and also available at this URL: > > Possibly use mtx_assert() rather than KASSERT(mtx_owned()) in > nfs_syscalls.c? Sounds good, I will make that change. I picked that new structure because it most closely matched what was there, and what was there required a KASSERT because it combined a variable check with a lock check, but the new code doesn't require that. Thanks, Robert N M Watson Computer Laboratory University of Cambridge
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070724192023.N15979>