Date: Fri, 6 Oct 1995 20:38:17 +0300 (MSK) From: =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= (aka Andrey A. Chernov, Black Mage) <ache@astral.msk.su> To: Satoshi Asami <asami@cs.berkeley.edu> Cc: CVS-commiters@freefall.freebsd.org, ache@freefall.freebsd.org, cvs-share@freefall.freebsd.org Subject: Re: cvs commit: src/share/mk bsd.port.mk Message-ID: <Tk9cMTmOW2@ache.dialup.demos.ru> In-Reply-To: <199510060227.TAA18885@forgery.CS.Berkeley.EDU>; from Satoshi Asami at Thu, 5 Oct 1995 19:27:05 -0700 References: <199510060227.TAA18885@forgery.CS.Berkeley.EDU>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <199510060227.TAA18885@forgery.CS.Berkeley.EDU> Satoshi
Asami writes:
> * >(2) Couldn't it have been done as a special target in the port
> * > Makefile instead of in a file that affects all the other ports?
> *
> * It can't be done as special target.
>I'm saying, couldn't you define a do-configure target in the ncftp2
>port to do that?
Yes, but 1) I need to copy whole configure rule adding yet one variable
assignment and need always to keep it in sync with main version 2) more
ports needs it, I'll plan to change them (after release).
> * It not affects other ports if you don't set CONFIGURE_ENV
> * variable directly.
> *
> * >(3) If not, should this go int 2.1R?
> *
> * It will be nice, if goes.
>You just created an inconsistency between the ports tree and
>bsd.port.mk. If this change doesn't go in, then the ncftp2 port won't
>compile correctly.
No, it compiles like it was before. In this case it will use compatibility
stuff from ncurses (instead of correct function) which goes away
with current ncurses version (we don't have it yet).
> * It not affects any ports.
>How do you know? The only way to be sure is to compile all ports, you
>know.
> * If you simple look at my change in bsd.port.mk (2 lines affected), you'll
> * have less questions about it.
>I did, it looks harmless enough, but I've seen real innocent-looking
>changes break some ports in the most weird ways.
Sigh.
some_rule:
xxx ${CONFIGURE_ENV} yyy
How it can cause _any_ problems, when CONFIGURE_ENV not set?
>But please don't touch bsd.port.mk without asking me first, ok? You
>are making my life much harder, a simple e-mail message won't hurt,
>don't you think so?
Ok, Ok.
--
Andrey A. Chernov : And I rest so composedly, /Now, in my bed,
ache@astral.msk.su : That any beholder /Might fancy me dead -
FidoNet: 2:5020/230.3 : Might start at beholding me, /Thinking me dead.
RELCOM Team,FreeBSD Team : E.A.Poe From "For Annie" 1849
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Tk9cMTmOW2>