Date: Mon, 16 Dec 2013 21:40:29 +0000 From: "Teske, Devin" <Devin.Teske@fisglobal.com> To: Nathan Whitehorn <nwhitehorn@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, Devin Teske <dteske@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "Teske, Devin" <Devin.Teske@fisglobal.com> Subject: Re: svn commit: r259479 - head/usr.sbin/bsdinstall/scripts Message-ID: <7BF56E5D-CDE7-4E57-BA47-3565CD07236C@fisglobal.com> In-Reply-To: <52AF6FF6.1030909@freebsd.org> References: <201312161947.rBGJl4Jh087762@svn.freebsd.org> <52AF6FF6.1030909@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Dec 16, 2013, at 1:26 PM, Nathan Whitehorn wrote: > On 12/16/13 13:47, Devin Teske wrote: >> Author: dteske >> Date: Mon Dec 16 19:47:04 2013 >> New Revision: 259479 >> URL: https://urldefense.proofpoint.com/v1/url?u=3Dhttp://svnweb.freebsd.= org/changeset/base/259479&k=3D%2FbkpAUdJWZuiTILCq%2FFnQg%3D%3D%0A&r=3DMrjs6= vR4%2Faj2Ns9%2FssHJjg%3D%3D%0A&m=3DfW6SVzmwwyz0yNXNK7sHp4zegrL63niU%2F%2F21= DVtgyGU%3D%0A&s=3Dcdd7f18e0151f222c2934ae69e473dac2e22e74cbde4d5af5758a083f= b1c3a7e >>=20 >> Log: >> Add kern.geom.label.disk_ident.enable=3D"0" to loader.conf(5). >> Discussed on: -current, -stable >> MFC after: 3 days >>=20 >> Modified: >> head/usr.sbin/bsdinstall/scripts/zfsboot >>=20 >> Modified: head/usr.sbin/bsdinstall/scripts/zfsboot >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/usr.sbin/bsdinstall/scripts/zfsboot Mon Dec 16 19:44:45 2013 (r= 259478) >> +++ head/usr.sbin/bsdinstall/scripts/zfsboot Mon Dec 16 19:47:04 2013 (r= 259479) >> @@ -1159,6 +1159,9 @@ zfs_create_boot() >> $BSDINSTALL_TMPETC/rc.conf.zfs || return $FAILURE >> f_eval_catch $funcname echo "$ECHO_APPEND" 'zfs_load=3D\"YES\"' \ >> $BSDINSTALL_TMPBOOT/loader.conf.zfs || return $FAILURE >> + f_eval_catch $funcname echo "$ECHO_APPEND" \ >> + 'kern.geom.label.disk_ident.enable=3D\"0\"' \ >> + $BSDINSTALL_TMPBOOT/loader.conf.zfs || return $FAILURE >> # We're all done unless we should go on for boot pool >> [ "$ZFSBOOT_BOOT_POOL" ] || return $SUCCESS >=20 > Uh -- what is all of this? Why are we disabling kernel functions dependin= g on what the root filesystem is? Please don't MFC this. http://lists.freebsd.org/pipermail/freebsd-stable/2013-December/076365.html http://lists.freebsd.org/pipermail/freebsd-stable/2013-December/076471.html NB: Happy to rip it out... but want something in-reply to those threads (pr= etty please). --=20 Devin _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7BF56E5D-CDE7-4E57-BA47-3565CD07236C>