Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 10 Oct 2015 17:59:47 +0300
From:      Roman Bogorodskiy <bogorodskiy@gmail.com>
To:        Bryan Drewery <bdrewery@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r398953 - head/Mk
Message-ID:  <20151010145946.GA12463@kloomba.lvv.mirantis.net>
In-Reply-To: <201510091920.t99JKO1Z074092@repo.freebsd.org>
References:  <201510091920.t99JKO1Z074092@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--h31gzZEtNLTqOjlF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

  Bryan Drewery wrote:

> Author: bdrewery
> Date: Fri Oct  9 19:20:24 2015
> New Revision: 398953
> URL: https://svnweb.freebsd.org/changeset/ports/398953
>=20
> Log:
>   Don't include/parse bsd.options.desc.mk if not needed (showconfig or -V=
 *_DESC).
>  =20
>   This is targetting dependency listing overhead.
>  =20
>   With hat:	portmgr
>=20
> Modified:
>   head/Mk/bsd.port.mk
>=20
> Modified: head/Mk/bsd.port.mk
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/Mk/bsd.port.mk	Fri Oct  9 19:09:27 2015	(r398952)
> +++ head/Mk/bsd.port.mk	Fri Oct  9 19:20:24 2015	(r398953)
> @@ -5293,7 +5293,7 @@ config-conditional:
>  .endif
>  .endif # config-conditional
> =20
> -.if !target(showconfig)
> +.if !target(showconfig) && (make(showconfig) || (!empty(.MAKEFLAGS:M-V) =
&& !empty(.MAKEFLAGS:M*_DESC)))
>  .include "${PORTSDIR}/Mk/bsd.options.desc.mk"
>  MULTI_EOL=3D	: you have to choose at least one of them
>  SINGLE_EOL=3D	: you have to select exactly one of them

This breaks displaying of standard options' description
in the 'make config' dialog.

Roman Bogorodskiy

--h31gzZEtNLTqOjlF
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJWGSfiAAoJEMltX/4IwiJqGwwH/j7S4GDPPHbCxdWABPwv8HIz
7wccl1GffQDTwsRmkjRCvzpLkkFnIP+u1ov9j/pLU94/SU0eXpXls3I5WJCkrfGL
H4ZIMK1R+YMbuA0krLw2UNuMvNfk6mKNNO6qlVp2FoSHN6xCCZ9ICAQ/nzPzoCG3
yXgDBsaGXgIsOVu5YjC0Fqng9YwbntY35DWzd94nNOM7c7y32E3LE1K12mub9xrL
j1NO3LiEgEn5eav/H4o1fI2AqDDt8FI+fof5m1P4VkmeUMpkUmrtglUFlKsY+yoe
tZKI1IOJ7ngIf2cl6/bexKxKYcCu7mrdyJNil6b63yAWdMyNjnvsHawB++vlnsU=
=a0LB
-----END PGP SIGNATURE-----

--h31gzZEtNLTqOjlF--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151010145946.GA12463>