Date: Wed, 13 Jul 2011 11:42:40 -0500 From: Stephen Montgomery-Smith <stephen@missouri.edu> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: Pav Lucistnik <pav@FreeBSD.org>, Stephen Montgomery-Smith <stephen@FreeBSD.org>, "freebsd-ports@freebsd.org" <freebsd-ports@FreeBSD.org> Subject: Re: [RFC] A trivial change for DESKTOP_ENTRIES Message-ID: <4E1DCB00.2030906@missouri.edu> In-Reply-To: <201107131141.43840.jkim@FreeBSD.org> References: <201107121826.00020.jkim@FreeBSD.org> <4E1D8408.1080609@FreeBSD.org> <201107131141.43840.jkim@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07/13/2011 10:41 AM, Jung-uk Kim wrote: > On Wednesday 13 July 2011 07:39 am, Pav Lucistnik wrote: >> On 2011/07/13 00:25, Jung-uk Kim wrote: >>> After I updated x11-wm/compiz, GNOME was not able to start the >>> window manager. Basically, it complained that compiz-manager was >>> not found. Then, I realized compiz-manager.desktop was >>> automagically replaced by compizmanager.desktop. Now I tracked >>> it down to this commit: >>> >>> Sat Nov 27 17:42:46 2010 UTC (7 months, 2 weeks ago) by pav >>> >>> - DESKTOP_ENTRIES: commandline is used to name installed .desktop >>> file, this can lead to files containing whitespace and funny >>> characters; thus strip all non-alphanumeric characters >>> >>> http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.port.mk.diff?r >>> 1=1.656;r2=1.657 >>> >>> To me, it looks far too restrictive. At least, I'd like to allow >>> '-' and '_'. Please see the attached patch. >>> >>> Any objections? >> >> Shouldn't you fix whatever is trying to call compizmanager not to >> use .desktop file instead? > > GNOME session manager calls the compiz-manager, i.e., the user has to > change it manually. Actually, x11-wm/compiz/pkg-message recommended > this: > > "If you are using gnome, you can use the configuration editor to set > the value of: > > desktop->gnome->session->required_components->windowmanager = > compiz-manager > ^^^^^^^^^^^^^^ > > This will enable compiz as your default window manager." > > I am quite sure there are similar instructions on the net. > > Jung-uk Kim Also, bsd.ports.mk shouldn't change what the port tells it to do, without informing anybody. I'm sure it took Jung-uk Kim many hours to figure out why it wasn't working. Other users are going to be in a similar spot. Many users will never figure it out.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E1DCB00.2030906>