Date: Tue, 25 Jan 2005 21:34:58 -0800 From: Michael Sierchio <ducatista@camber-thrust.net> To: Joe Marcus Clarke <marcus@marcuscom.com> Cc: lioux@freebsd.org Subject: Re: FreeBSD Port: qmail-1.03_3 Message-ID: <41F72C02.7060901@camber-thrust.net> In-Reply-To: <1106704507.16118.14.camel@shumai.marcuscom.com> References: <41F6F431.6060005@tenebras.com> <1106704507.16118.14.camel@shumai.marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Joe Marcus Clarke wrote: >>- while ((k > i) && (cmds.s[k - 1] == ' ') || (cmds.s[k - 1] == '\t')) >>+ while ((k > i) && ((cmds.s[k - 1] == ' ') || (cmds.s[k - 1] == '\t'))) > Actually, if k is less than or equal to i and cmds.s[k-1] is a tab, then > the first bit of code evaluates to true while the second evaluates to > false. I haven't looked at the rest of the code, but those statements > are semantically different, and I think the second is more correct. You're simply mistaken. ( 1 && 0 || 1 ) will ALWAYS evaluate to 1 on any ANSI C compiler. There was no bug corrected by this mess: http://www.freebsd.org/cgi/cvsweb.cgi/ports/mail/qmail/files/patch-qmail-local.c?rev=1.1&content-type=text/x-cvsweb-markup ports/mail/qmail/files/patch-qmail-local.c - view - 1.1 only a perceived bug because of a lack of understanding of how operators are evaluated. The author should have been contacted if there were indeed a bug. I assure you, there is not. 4) Add qmail's sendmail emulation fix: "David Phillips noticed that sendmail's '-f' option sets a default From: header, and so should qmail's emulation." - Add distinfo checksum for the patch This is also bogus, IMO -- feature addition to software which has been well-audited and which makes security claims is simply a bad idea.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41F72C02.7060901>