Date: Sat, 10 Jan 2015 19:46:10 +0100 From: John Marino <freebsd.contact@marino.st> To: Antoine Brodin <antoine@FreeBSD.org>, John Marino <marino@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r376718 - head/lang/fpc Message-ID: <54B17372.8000205@marino.st> In-Reply-To: <CAALwa8mbMYqWi5yzUkMSYhmc5H0arZy14emRX0hxQBTrL0TUGw@mail.gmail.com> References: <201501101755.t0AHtrTf069687@svn.freebsd.org> <54B16EA4.2070106@marino.st> <CAALwa8mbMYqWi5yzUkMSYhmc5H0arZy14emRX0hxQBTrL0TUGw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1/10/2015 19:37, Antoine Brodin wrote: > On Sat, Jan 10, 2015 at 6:25 PM, John Marino <freebsd.contact@marino.st> wrote: >> On 1/10/2015 18:55, Antoine Brodin wrote: >>> Author: antoine >>> Date: Sat Jan 10 17:55:52 2015 >>> New Revision: 376718 >>> URL: https://svnweb.freebsd.org/changeset/ports/376718 >>> QAT: https://qat.redports.org/buildarchive/r376718/ >>> >>> Log: >>> Revert part of r376655 that is breaks freebsd ports >>> >>> With hat: portmgr >>> >> >> I'm going to go danfe here and request some clarification. This commit >> message does not indicate what exactly broke. Did fpmkunit not build? >> Is there a log? Why did portmgr have to step in versus asking the >> maintainer to look into it? >> > > Yes it broke fpmkunit, did you test on freebsd? > Your commit was supposed to be a nop for freebsd but it wasn't so I > reverted, supporting dragonfly is nice but breaking freebsd is not. Yes, I *only* used FreeBSD for testing. I built some extensions, not all 100 of them. It built everything I tested. >From your answer, I can't tell if fpmkunit built and didn't work, or just didn't build. I still think the maintainer / committer should be asked to look at it rather than instantly reverting. This wasn't a broken index or something like that. I mean, a few hours notice before reverting would have been ok, no? John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54B17372.8000205>