Date: Tue, 22 Nov 2005 22:38:19 +0200 From: Ruslan Ermilov <ru@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/acpica acpi_pci_link.c Message-ID: <20051122203819.GA94180@ip.net.ua> In-Reply-To: <200511221050.41796.jhb@freebsd.org> References: <200511212201.jALM1Ggp080941@repoman.freebsd.org> <20051122143721.GE65080@ip.net.ua> <200511221050.41796.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--7JfCtLOvnd9MIVvH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 22, 2005 at 10:50:39AM -0500, John Baldwin wrote: > On Tuesday 22 November 2005 09:37 am, Ruslan Ermilov wrote: > > On Mon, Nov 21, 2005 at 10:01:16PM +0000, John Baldwin wrote: > > > jhb 2005-11-21 22:01:16 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/dev/acpica acpi_pci_link.c > > > Log: > > > Fix the code to look up the BIOS IRQ for a given link device by rea= ding > > > the IRQ set by the BIOS in existing devices to actually get the cor= rect > > > bus number of the child PCI bus. I was not reading the bus number = =66rom > > > the bridge device correctly. The __BUS_ACCESSOR() macros (from whi= ch > > > pcib_get_bus() is built) assume that the passed in argument is a ch= ild > > > device. However, at the time I'm reading the bus there is no child > > > device yet, so I was passing in the pcib device as the child device. > > > The parent of the pcib device probably returned an error in the cas= e of > > > a host bridge, thus resulting in random stack garbage for the bus > > > number. For PCI-PCI bridges, the bus number being used was actually t= he > > > subvendor of the PCI-PCI bridge device itself. > > > > > > MFC after: 1 week > > > > > > Revision Changes Path > > > 1.49 +15 -3 src/sys/dev/acpica/acpi_pci_link.c > > > > Looks like I no longer need these hw.pci.link.LNK[A-D].irq=3D11 > > in /boot/loader.conf after this change. >=20 > Woah, that's a good fix then. This was on a T43? >=20 No, 600X. I tried verbose booting with and without ACPI, and with and without these tunables, and don't see any difference. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --7JfCtLOvnd9MIVvH Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDg4G7qRfpzJluFF4RAhuSAJ9FRpLZPTq36P0Y5fUccWD5kzZCLwCfUqGg DzJU7BykifDZntwgpgn+Zqs= =vlim -----END PGP SIGNATURE----- --7JfCtLOvnd9MIVvH--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051122203819.GA94180>