Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 22 Feb 2009 20:11:10 +0000 (UTC)
From:      Alan Cox <alc@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-user@freebsd.org
Subject:   svn commit: r188931 - user/alc/pagelock/sys/fs/tmpfs
Message-ID:  <200902222011.n1MKBA3i005434@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: alc
Date: Sun Feb 22 20:11:10 2009
New Revision: 188931
URL: http://svn.freebsd.org/changeset/base/188931

Log:
  Eliminate unnecessary page queues locking.

Modified:
  user/alc/pagelock/sys/fs/tmpfs/tmpfs_vnops.c

Modified: user/alc/pagelock/sys/fs/tmpfs/tmpfs_vnops.c
==============================================================================
--- user/alc/pagelock/sys/fs/tmpfs/tmpfs_vnops.c	Sun Feb 22 19:59:41 2009	(r188930)
+++ user/alc/pagelock/sys/fs/tmpfs/tmpfs_vnops.c	Sun Feb 22 20:11:10 2009	(r188931)
@@ -569,9 +569,7 @@ lookupvpg:
 		if (vm_page_sleep_if_busy(vpg, FALSE, "tmfsmw"))
 			goto lookupvpg;
 		vm_page_busy(vpg);
-		vm_page_lock_queues();
 		vm_page_undirty(vpg);
-		vm_page_unlock_queues();
 		VM_OBJECT_UNLOCK(vobj);
 		error = uiomove_fromphys(&vpg, offset, tlen, uio);
 	} else {
@@ -605,12 +603,12 @@ nocache:
 out:
 	if (vobj != NULL)
 		VM_OBJECT_LOCK(vobj);
-	vm_page_lock_queues();
 	if (error == 0) {
 		vm_page_set_validclean(tpg, offset, tlen);
 		vm_page_zero_invalid(tpg, TRUE);
 		vm_page_dirty(tpg);
 	}
+	vm_page_lock_queues();
 	vm_page_unwire(tpg, TRUE);
 	vm_page_unlock_queues();
 	vm_page_wakeup(tpg);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200902222011.n1MKBA3i005434>