Date: Fri, 12 Dec 2008 07:59:46 -0500 From: Randall Stewart <rrs@lakerest.net> To: "Bruce M. Simpson" <bms@FreeBSD.org> Cc: freebsd-net <freebsd-net@FreeBSD.org> Subject: Re: Heads up --- Thinking about UDP and tunneling Message-ID: <57BBB796-7E00-4D96-BACE-1306FC4C1417@lakerest.net> In-Reply-To: <494157DF.6030802@FreeBSD.org> References: <D72E9703-C8E7-4A21-A71E-A4B4C2D7E8F4@lakerest.net> <49249443.8050707@elischer.org> <76CF7D15-251F-4E43-86BE-AD96F48AF123@lakerest.net> <200811201450.30016.max@love2party.net> <24BD4A21-E10D-4E09-8C33-3FCF930A0495@lakerest.net> <494157DF.6030802@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce: On Dec 11, 2008, at 1:11 PM, Bruce M. Simpson wrote: > Hi, > > I am missing context of what Max's suggestion was, do you have a > reference to an old email thread? As to the context... Nov 18 2008 10:01 (am Eastern) I started a thread "Thinking about UDP and tunneling" > > > Style bugs: > * needs style(9) and whitespace cleanup. Hmm.. I thought I had got all this stuff... I actually (shudder) switched to vi since my emacs spacing always messes up.. in the SCTP code I have the s9indent function that fixes any issues.. but I did not want to run that on the udp src and cause other changes ... I will go back and look at the patch.. > > * C typedefs should be suffixed with _t for consistency with other > kernel typedefs. Good point I will fix the stuff to have _t in it :-) > > * Function typedefs usually named like foo_func_t (see other > subsystems) R > > > Have you looked at m_apply() ? It already exists for stuff like this > i.e. functions which act on an mbuf chain, although it doesn't > necessarily expect chain heads. > > cheers > BMS > ------------------------------ Randall Stewart 803-317-4952 (cell) 803-345-0391(direct)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?57BBB796-7E00-4D96-BACE-1306FC4C1417>