Date: Sun, 24 Feb 2008 19:21:56 -0800 (PST) From: Amatus <c11h15no2@yahoo.com> To: Joe Marcus Clarke <marcus@marcuscom.com> Cc: freebsd-gnome@freebsd.org Subject: Re: Question about updating guile to 1.8 Message-ID: <768666.6725.qm@web30006.mail.mud.yahoo.com> In-Reply-To: <963757.68467.qm@web30005.mail.mud.yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--0-1356277426-1203909716=:6725
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Content-Id:
Content-Disposition: inline
--- Amatus <c11h15no2@yahoo.com> wrote:
>
> --- Joe Marcus Clarke <marcus@marcuscom.com> wrote:
>
> >
> > On Sun, 2008-02-24 at 14:24 -0800, Amatus wrote:
> > > Hi guys,
> > > I'm working on updating lang/guile to 1.8.
> >
> > Excellent.
> >
> > > I've basically got that
> > > working but there are several other ports that refer to
> > > ${LOCALBASE}/share/guile/1.6 that will need to be fixed. These
> are:
> > > security/lsh
> > > lang/slib-guile
> > > finance/gnucash
> > > I've just started doing port development so I'd like to ask what
> is
> > the
> > > correct way to fix these ports. What do you guys think of the
> > attached
> > > patch for lang/slib-guile?
> >
> > This patch is okay. But note that GUILE_VERSION is not expanded
> > until
> > it is used in sh. That is, GUILE_VERSION does NOT equal "1.8".
> You
> > will not be able to make it equal "1.8" until it is interpreted by
> > sh.
> > The way you're using it here is fine, though.
> >
> > As for the command itself, it should probably be:
> >
> > `${LOCALBASE}/bin/guile-config info guileversion | ${CUT} -f 1-2 -d
> > .`
> >
> > Are you in a position to be run-time testing these ports with the
> new
> > guile? Once you're done with your work, do you want to be the
> guile
> > maintainer?
> >
> > Joe
>
> I realize it's not expanded immediately. I know in GNU make there is
> the $(shell) syntax for doing that but I didn't find a way to do that
> in BSD make. Do you know the Right Way?
> I use gnucash regularly so I will give that a good exercising before
> I
> submit a patch. The other packages I will "smoke test," as they say,
> to
> make sure they don't explode when I run them.
> I'm ok with being the maintainer for guile. Thanks for your help.
>
I found out this trick doesn't work in RUN_DEPENDS in finance/gnucash,
and also that I needed to add a PLIST_SUB to lang/slib-guile. Now I'm
using != for GUILE_VER and it seems to be working better. Attached is
what my change for lang/slib-guile looks like now.
____________________________________________________________________________________
Looking for last minute shopping deals?
Find them fast with Yahoo! Search. http://tools.search.yahoo.com/newsearch/category.php?category=shopping
--0-1356277426-1203909716=:6725
Content-Type: application/octet-stream; name="slib-guile.patch"
Content-Transfer-Encoding: base64
Content-Description: 2510440456-slib-guile.patch
Content-Disposition: attachment; filename="slib-guile.patch"
ZGlmZiAtcnVOIGxhbmcvc2xpYi1ndWlsZS9NYWtlZmlsZSAvdXNyL3BvcnRz
L2xhbmcvc2xpYi1ndWlsZS9NYWtlZmlsZQotLS0gbGFuZy9zbGliLWd1aWxl
L01ha2VmaWxlCTIwMDgtMDItMjQgMjE6MTU6MjkuNDY5NDUyMjUxIC0wNjAw
CisrKyAvdXNyL3BvcnRzL2xhbmcvc2xpYi1ndWlsZS9NYWtlZmlsZQkyMDA3
LTAxLTI0IDEwOjE5OjIxLjAwMDAwMDAwMCAtMDYwMApAQCAtNyw3ICs3LDYg
QEAKIAogUE9SVE5BTUU9CXNsaWIKIFBPUlRWRVJTSU9OPQkzYTQgIyBLZWVw
IHRoaXMgaW4gc3luYyB3aXRoIGxhbmcvc2xpYgotUE9SVFJFVklTSU9OPQkx
CiBDQVRFR09SSUVTPQlsYW5nIHNjaGVtZQogTUFTVEVSX1NJVEVTPQkjIGVt
cHR5CiBQS0dOQU1FU1VGRklYPQktZ3VpbGUKQEAgLTIyLDE1ICsyMSwxMCBA
QAogCiBOT19CVUlMRD0JeWVzCiAKLS5pbmNsdWRlIDxic2QucG9ydC5wcmUu
bWs+Ci0KLUdVSUxFX1ZFUiE9CSR7TE9DQUxCQVNFfS9iaW4vZ3VpbGUtY29u
ZmlnIGluZm8gZ3VpbGV2ZXJzaW9uIHwgJHtDVVR9IC1mIDEtMiAtZCAuCi1Q
TElTVF9TVUI9CUdVSUxFX1ZFUj0ke0dVSUxFX1ZFUn0KLQogZG8taW5zdGFs
bDoKLQkke0xOfSAtc2hmICR7UFJFRklYfS9zaGFyZS9zbGliICR7TE9DQUxC
QVNFfS9zaGFyZS9ndWlsZS8ke0dVSUxFX1ZFUn0vc2xpYgotCWNkICR7UFJF
RklYfS9zaGFyZS9ndWlsZS8ke0dVSUxFX1ZFUn0vc2xpYiAmJiBcCisJJHtM
Tn0gLXNoZiAke1BSRUZJWH0vc2hhcmUvc2xpYiAke0xPQ0FMQkFTRX0vc2hh
cmUvZ3VpbGUvMS42L3NsaWIKKwljZCAke1BSRUZJWH0vc2hhcmUvZ3VpbGUv
MS42L3NsaWIgJiYgXAogCQkke0xPQ0FMQkFTRX0vYmluL2d1aWxlIC1xIC1s
IGd1aWxlLmluaXQgLWMgXAogCQkiKHJlcXVpcmUgJ25ldy1jYXRhbG9nKSIK
IAotLmluY2x1ZGUgPGJzZC5wb3J0LnBvc3QubWs+CisuaW5jbHVkZSA8YnNk
LnBvcnQubWs+CmRpZmYgLXJ1TiBsYW5nL3NsaWItZ3VpbGUvcGtnLXBsaXN0
IC91c3IvcG9ydHMvbGFuZy9zbGliLWd1aWxlL3BrZy1wbGlzdAotLS0gbGFu
Zy9zbGliLWd1aWxlL3BrZy1wbGlzdAkyMDA4LTAyLTI0IDIwOjUwOjM5LjE0
NzM1ODgwMSAtMDYwMAorKysgL3Vzci9wb3J0cy9sYW5nL3NsaWItZ3VpbGUv
cGtnLXBsaXN0CTIwMDYtMTAtMTQgMDM6MzU6NDEuMDAwMDAwMDAwIC0wNTAw
CkBAIC0xLDQgKzEsNCBAQAotQGV4ZWMgbG4gLXNoZiAlRC9zaGFyZS9zbGli
ICVEL3NoYXJlL2d1aWxlLyUlR1VJTEVfVkVSJSUvc2xpYgorQGV4ZWMgbG4g
LXNoZiAlRC9zaGFyZS9zbGliICVEL3NoYXJlL2d1aWxlLzEuNi9zbGliCiBA
ZXhlYyAlRC9iaW4vZ3VpbGUgLXEgLWwgJSVMT0NBTEJBU0UlJS9zaGFyZS9z
bGliL2d1aWxlLmluaXQgLWMgIihyZXF1aXJlICduZXctY2F0YWxvZykiCi1A
dW5leGVjIHJtIC1mICVEL3NoYXJlL2d1aWxlLyUlR1VJTEVfVkVSJSUvc2xp
YgotQHVuZXhlYyBybSAtZiAlRC9zaGFyZS9ndWlsZS8lJUdVSUxFX1ZFUiUl
L3NsaWJjYXQKK0B1bmV4ZWMgcm0gLWYgJUQvc2hhcmUvZ3VpbGUvMS42L3Ns
aWIKK0B1bmV4ZWMgcm0gLWYgJUQvc2hhcmUvZ3VpbGUvMS42L3NsaWJjYXQK
--0-1356277426-1203909716=:6725--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?768666.6725.qm>