Date: Thu, 27 Nov 2014 14:09:03 +0000 From: Miguel Clara <miguelmclara@gmail.com> To: Poul-Henning Kamp <phk@phk.freebsd.dk>, Konstantin Belousov <kostikbel@gmail.com> Cc: Davide Italiano <davide@freebsd.org>, Ed Schouten <ed@80386.nl>, freebsd-current <freebsd-current@freebsd.org> Subject: Re: RFC: Remove pty(4) Message-ID: <82FE1213-64CD-41FE-92F2-46743641803A@gmail.com> In-Reply-To: <90480.1417092116@critter.freebsd.dk> References: <CACYV=-E1BA3rHP5s%2BCs-X-J5CNAaSNxDgqPkgnJu3uUXCyaUGA@mail.gmail.com> <1471750.VzNR6ldJSe@ralph.baldwin.cx> <CACYV=-FLkKzHRuD7je9x4qB-AtOrBgi6y4fsUEQUy_GhRezhuA@mail.gmail.com> <20141127095229.GO17068@kib.kiev.ua> <90480.1417092116@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
I've recently created a port for linux-sublime and some of the packages users might add to sublime require loading pty. I haven't read the full thread so I'm not sure what would actually be removed but If there no reason for it I don't see why waste the time on such a task. is there for example any security concern about using the pty driver? thanks On 27 November 2014 12:41:56 WET, Poul-Henning Kamp <phk@phk.freebsd.dk> wrote: >-------- >In message <20141127095229.GO17068@kib.kiev.ua>, Konstantin Belousov >writes: > >>On Wed, Nov 26, 2014 at 04:41:27PM -0800, Davide Italiano wrote: >>> On Mon, Aug 25, 2014 at 12:37 PM, John Baldwin <jhb@freebsd.org> >wrote: >>> > On Wednesday, August 20, 2014 11:00:14 AM Davide Italiano wrote: >>> >> One of my personal goals for 11 is to get rid of cloning >mechanism >>> >> entirely, and pty(4) is one of the few in-kernel drivers still >relying >>> >> on such mechanism. >>Why this is good thing to do ? > >I must have missed this detail back in august. > >I checked my archive of incoming email and I couldn't find any >reason or argument for removing dev_clone mechanism, and I would >very much object to its removal, unless a very compelling reason >exists ? > >I'll admit that the name is slightly misleading, it is really >a "dev_ondemand" facility which can also be used for cloning, >and because all the initial uses were cloning it got that name. > >(I have no soft feelings for the pty driver) > >-- >Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 >phk@FreeBSD.ORG | TCP/IP since RFC 956 >FreeBSD committer | BSD since 4.3-tahoe >Never attribute to malice what can adequately be explained by >incompetence. >_______________________________________________ >freebsd-current@freebsd.org mailing list >http://lists.freebsd.org/mailman/listinfo/freebsd-current >To unsubscribe, send any mail to >"freebsd-current-unsubscribe@freebsd.org" -- Sent from my Android device with K-9 Mail. Please excuse my brevity. From owner-freebsd-current@FreeBSD.ORG Thu Nov 27 17:10:23 2014 Return-Path: <owner-freebsd-current@FreeBSD.ORG> Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2F12DFB6; Thu, 27 Nov 2014 17:10:23 +0000 (UTC) Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DF729F40; Thu, 27 Nov 2014 17:10:22 +0000 (UTC) Received: from laptop015.home.selasky.org (cm-176.74.213.204.customer.telag.net [176.74.213.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id DC2811FE022; Thu, 27 Nov 2014 18:10:12 +0100 (CET) Message-ID: <54775B0E.3000004@selasky.org> Date: Thu, 27 Nov 2014 18:10:38 +0100 From: Hans Petter Selasky <hps@selasky.org> User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: "K. Macy" <kmacy@freebsd.org> Subject: Re: [RFC] Removal of M_FLOWID flag from m_flags [WAS: Add support for hardware transmit rate limiting queues] References: <546CE948.2070105@selasky.org> <CAHM0Q_NwfjH-XqwTaRiZdntAiT=73-dETogQRWeyhEZQm-Ky2Q@mail.gmail.com> <546D0CE3.602@selasky.org> In-Reply-To: <546D0CE3.602@selasky.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Lawrence Stewart <lstewart@freebsd.org>, Adrian Chadd <adrian@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org>, Luigi Rizzo <rizzo@iet.unipi.it>, Navdeep Parhar <np@freebsd.org> X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current <freebsd-current.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>; List-Post: <mailto:freebsd-current@freebsd.org> List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, <mailto:freebsd-current-request@freebsd.org?subject=subscribe> X-List-Received-Date: Thu, 27 Nov 2014 17:10:23 -0000 On 11/19/14 22:34, Hans Petter Selasky wrote: > On 11/19/14 21:46, K. Macy wrote: >> Hi Hans, >> >> It mostly looks fine, but it's a large change and there are some >> places in the patch where it isn't clear that the right thing is being >> done by looking at the patch alone. Please give us some time to >> review. >> > > No problem. Do you think you need more than a week? > > --HPS > Hi, Do you need more time to review my patch? Any issues that should be fixed? --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?82FE1213-64CD-41FE-92F2-46743641803A>