Date: Tue, 4 Oct 2016 13:27:04 +0100 From: Bob Eager <rde@tavi.co.uk> To: freebsd-ports@freebsd.org Subject: Re: LICENSE questions Message-ID: <20161004132704.7a52b810@raksha.tavi.co.uk> In-Reply-To: <614130db-1846-3c97-e94b-7962adc604d0@FreeBSD.org> References: <b2a4e74d-cbe3-d70e-553c-dcfbdc9442f1@missouri.edu> <CAF6rxgmQuK31iiNoE57sJcTVaqDdSmB6Pf%2BBYwmbWWBtrtYGYg@mail.gmail.com> <d456df7f-259e-8c1b-5178-8e9a5e948718@missouri.edu> <CAF6rxg=uSmn05Kc6sHycwF=FYO%2BhrRVLJi5NNPd4hVq=oott_w@mail.gmail.com> <11cf69da-01ed-e7c3-9c2b-2291e22ab6e9@missouri.edu> <126e66dd-8cee-2475-f44d-193934d1f587@FreeBSD.org> <CAF6rxgndWSMTDRHtG3FNb1m1ZrvZeYUfQwo8kXcS=QpC6i5RbA@mail.gmail.com> <fd3fcd46-6950-9fb9-0272-09d35f7fb158@FreeBSD.org> <c593c4c4-0903-400d-0f9f-4452278246b3@missouri.edu> <614130db-1846-3c97-e94b-7962adc604d0@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 4 Oct 2016 14:15:28 +0200 Mathieu Arnold <mat@FreeBSD.org> wrote: > Le 04/10/2016 =E0 14:03, Montgomery-Smith, Stephen a =E9crit : > > On 10/04/2016 06:47 AM, Mathieu Arnold wrote: =20 > >> Le 04/10/2016 =E0 09:29, Eitan Adler a =E9crit : =20 > >>> On 4 October 2016 at 00:25, Mathieu Arnold <mat@freebsd.org> > >>> wrote: =20 > >>>> Le 04/10/2016 =E0 03:58, Montgomery-Smith, Stephen a =E9crit : =20 > >>>>> Could we use USES=3Dmetaport to suppress these messages? =20 > >>>> Suppress what messages ? =20 > >>> 115 .if defined(LICENSE) > >>> 119 .else > >>> 120 DEV_WARNING+=3D "Please set LICENSE for this port" > >>> 121 .endif =20 > >> Mmmm, this is a warning, not an error, it tells you "dude, maybe > >> you need to do this". > >> I don't see a good reason to complicate the logic more. > >> =20 > > Because naive port maintainers like myself might think they should > > add a LICENSE to any metaport they happen to own. > > > > One of the issues I have with LICENSE is that I don't see anything > > about it in the porters handbook. Otherwise that would be an > > excellent place to tell maintainers of metaports not to license > > them. =20 >=20 > Nobody stepped up to write a LICENSE section. I started writing > https://reviews.freebsd.org/D56 but it is crappy. >=20 > > Also the tone is quite commanding. If it said "Consider setting > > LICENSE for this port", that would be more acceptable. Really, I > > think it should say "Please set LICENSE for this port, unless this > > is a metaport". =20 >=20 > Feel free to make the message better, it is in Mk/bsd.sanity.mk. I believe portlint uses 'Consider'. On the other hand, I had a new port and the committer insisted I had LICENSE in there.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161004132704.7a52b810>