Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 20 Jun 2006 23:07:12 +0300 (EEST)
From:      Dmitry Pryanishnikov <dmitry@atlantis.dp.ua>
To:        John Baldwin <jhb@freebsd.org>
Cc:        Adi Pircalabu <apircalabu@bitdefender.com>, freebsd-current@freebsd.org, Hajimu UMEMOTO <ume@freebsd.org>, Ivan Voras <ivoras@fer.hr>, "current@freebsd.org" <current@freebsd.org>
Subject:   Re: Linux-flashplugin7 & rtld - RFC
Message-ID:  <20060620230149.S43840@atlantis.atlantis.dp.ua>
In-Reply-To: <200606201002.07695.jhb@freebsd.org>
References:  <449015DE.6090407@fer.hr> <ygemzcd9ji5.wl%ume@mahoroba.org> <20060616211540.D37640@atlantis.atlantis.dp.ua> <200606201002.07695.jhb@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

Hello!

On Tue, 20 Jun 2006, John Baldwin wrote:
>>> This patch is somewhat redundant.  Adding
>>>
>>> 	__weak_reference(dlsym, _dlsym);
>>>
>>> is enough.
>>
>>   Indeed, this also works for me. It would be nice to see this trivial
>> addition committed.
>
> I agree.  Do you have the __weak_reference() patch handy?

  Sure, here is the diff against HEAD:

--- libexec/rtld-elf/rtld.c.orig        Tue Mar 28 10:17:21 2006
+++ libexec/rtld-elf/rtld.c     Tue Jun 20 22:35:17 2006
@@ -137,6 +137,8 @@

  void r_debug_state(struct r_debug*, struct link_map*);

+__weak_reference(dlsym, _dlsym);
+
  /*
   * Data declarations.
   */

I'm not sure whether it's style(9)-compliant, it just works.

> John Baldwin

Sincerely, Dmitry
-- 
Atlantis ISP, System Administrator
e-mail:  dmitry@atlantis.dp.ua
nic-hdl: LYNX-RIPE



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060620230149.S43840>