Date: Sat, 20 Jan 2001 17:29:34 -0500 (EST) From: Daniel Eischen <eischen@vigrid.com> To: Jason Evans <jasone@canonware.com> Cc: "Jacques A. Vidrine" <n@nectar.com>, arch@freebsd.org Subject: Re: Request For Review: libc/libc_r changes to allow -lc_r Message-ID: <Pine.SUN.3.91.1010120172734.8403B-100000@pcnet1.pcnet.com> In-Reply-To: <20010120134926.P69199@canonware.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 20 Jan 2001, Jason Evans wrote: > On Sat, Jan 20, 2001 at 03:31:58PM -0600, Jacques A. Vidrine wrote: > > On Fri, Jan 19, 2001 at 07:38:00PM -0500, Daniel Eischen wrote: > > I have one objection: > > > > [snip] > > > _thread_sys_foo - actual syscall > > > _foo - weak definition to _thread_sys_foo > > > foo - weak definition to _thread_sys_foo > > > > > > I've changed all the instances of foo() to _foo() in libc for > > > those hidden system calls. Anyone modifying or adding to libc > > > will have to be careful to use the same conventions. > > > > Please, no. Kill `un-namespace' and let us continue to use the > > correct name for `foo'. Adding underscores in front of lotsa common > > calls hurt my eyes and hinders porting between different libc > > implementations (e.g. our `old' one, other *BSDs). > > Do you have any alternative suggestions? We have been doing this for a > number of system calls for almost a year in order to make thread > cancellation work, and I can't think of any way to make linking against > libc _and_ libpthread work correctly. I agree. We've spent a not-so-trivial amount of time making these changes, and I'd hate for us to have to go back to the drawing board. -- Dan Eischen To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.SUN.3.91.1010120172734.8403B-100000>