Skip site navigation (1)Skip section navigation (2) 
Date:      Mon, 8 Aug 2016 05:57:38 +0000 (UTC)
From:      Sepherosa Ziehau <sephe@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r303822 - head/sys/dev/hyperv/utilities
Message-ID:  <201608080557.u785vcZI012335@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: sephe
Date: Mon Aug  8 05:57:38 2016
New Revision: 303822
URL: https://svnweb.freebsd.org/changeset/base/303822

Log:
  hyperv/ic: Remove never used second parameter of hv_negotiate_version()
  
  MFC after:	1 week
  Sponsored by:	Microsoft
  Differential Revision:	https://reviews.freebsd.org/D7422

Modified:
  head/sys/dev/hyperv/utilities/hv_heartbeat.c
  head/sys/dev/hyperv/utilities/hv_shutdown.c
  head/sys/dev/hyperv/utilities/hv_timesync.c
  head/sys/dev/hyperv/utilities/hv_util.c
  head/sys/dev/hyperv/utilities/hv_util.h

Modified: head/sys/dev/hyperv/utilities/hv_heartbeat.c
==============================================================================
--- head/sys/dev/hyperv/utilities/hv_heartbeat.c	Mon Aug  8 05:57:04 2016	(r303821)
+++ head/sys/dev/hyperv/utilities/hv_heartbeat.c	Mon Aug  8 05:57:38 2016	(r303822)
@@ -75,8 +75,7 @@ hv_heartbeat_cb(struct vmbus_channel *ch
 		&buf[sizeof(struct hv_vmbus_pipe_hdr)];
 
 	    if (icmsghdrp->icmsgtype == HV_ICMSGTYPE_NEGOTIATE) {
-		hv_negotiate_version(icmsghdrp, NULL, buf);
-
+		hv_negotiate_version(icmsghdrp, buf);
 	    } else {
 		heartbeat_msg =
 		    (struct hv_vmbus_heartbeat_msg_data *)

Modified: head/sys/dev/hyperv/utilities/hv_shutdown.c
==============================================================================
--- head/sys/dev/hyperv/utilities/hv_shutdown.c	Mon Aug  8 05:57:04 2016	(r303821)
+++ head/sys/dev/hyperv/utilities/hv_shutdown.c	Mon Aug  8 05:57:38 2016	(r303822)
@@ -79,8 +79,7 @@ hv_shutdown_cb(struct vmbus_channel *cha
 		&buf[sizeof(struct hv_vmbus_pipe_hdr)];
 
 	    if (icmsghdrp->icmsgtype == HV_ICMSGTYPE_NEGOTIATE) {
-		hv_negotiate_version(icmsghdrp, NULL, buf);
-
+		hv_negotiate_version(icmsghdrp, buf);
 	    } else {
 		shutdown_msg =
 		    (struct hv_vmbus_shutdown_msg_data *)

Modified: head/sys/dev/hyperv/utilities/hv_timesync.c
==============================================================================
--- head/sys/dev/hyperv/utilities/hv_timesync.c	Mon Aug  8 05:57:04 2016	(r303821)
+++ head/sys/dev/hyperv/utilities/hv_timesync.c	Mon Aug  8 05:57:38 2016	(r303822)
@@ -155,7 +155,7 @@ hv_timesync_cb(struct vmbus_channel *cha
 		sizeof(struct hv_vmbus_pipe_hdr)];
 
 	    if (icmsghdrp->icmsgtype == HV_ICMSGTYPE_NEGOTIATE) {
-		hv_negotiate_version(icmsghdrp, NULL, time_buf);
+		hv_negotiate_version(icmsghdrp, time_buf);
 	    } else {
 		timedatap = (struct hv_ictimesync_data *) &time_buf[
 		    sizeof(struct hv_vmbus_pipe_hdr) +

Modified: head/sys/dev/hyperv/utilities/hv_util.c
==============================================================================
--- head/sys/dev/hyperv/utilities/hv_util.c	Mon Aug  8 05:57:04 2016	(r303821)
+++ head/sys/dev/hyperv/utilities/hv_util.c	Mon Aug  8 05:57:38 2016	(r303822)
@@ -45,11 +45,10 @@
 #include "hv_util.h"
 
 void
-hv_negotiate_version(
-	struct hv_vmbus_icmsg_hdr*		icmsghdrp,
-	struct hv_vmbus_icmsg_negotiate*	negop,
-	uint8_t*				buf)
+hv_negotiate_version(struct hv_vmbus_icmsg_hdr *icmsghdrp, uint8_t *buf)
 {
+	struct hv_vmbus_icmsg_negotiate *negop;
+
 	icmsghdrp->icmsgsize = 0x10;
 
 	negop = (struct hv_vmbus_icmsg_negotiate *)&buf[

Modified: head/sys/dev/hyperv/utilities/hv_util.h
==============================================================================
--- head/sys/dev/hyperv/utilities/hv_util.h	Mon Aug  8 05:57:04 2016	(r303821)
+++ head/sys/dev/hyperv/utilities/hv_util.h	Mon Aug  8 05:57:38 2016	(r303822)
@@ -43,11 +43,9 @@ typedef struct hv_util_sc {
 	uint8_t			*receive_buffer;
 } hv_util_sc;
 
-void hv_negotiate_version(
-	struct hv_vmbus_icmsg_hdr*		icmsghdrp,
-	struct hv_vmbus_icmsg_negotiate*	negop,
-	uint8_t*				buf);
+void hv_negotiate_version(struct hv_vmbus_icmsg_hdr *icmsghdrp, uint8_t *buf);
 
 int hv_util_attach(device_t dev);
 int hv_util_detach(device_t dev);
+
 #endif

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201608080557.u785vcZI012335>