Date: Mon, 09 Mar 2015 09:58:36 -0600 From: Ian Lepore <ian@freebsd.org> To: Warner Losh <imp@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r279814 - head/sys/arm/conf Message-ID: <1425916716.73796.28.camel@freebsd.org> In-Reply-To: <201503091543.t29FhYVu081001@svn.freebsd.org> References: <201503091543.t29FhYVu081001@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 2015-03-09 at 15:43 +0000, Warner Losh wrote: > Author: imp > Date: Mon Mar 9 15:43:33 2015 > New Revision: 279814 > URL: https://svnweb.freebsd.org/changeset/base/279814 > > Log: > Add the DTrace modules to the build, rather than only build the dtrace > modules. > > Modified: > head/sys/arm/conf/BEAGLEBONE > > Modified: head/sys/arm/conf/BEAGLEBONE > ============================================================================== > --- head/sys/arm/conf/BEAGLEBONE Mon Mar 9 15:31:33 2015 (r279813) > +++ head/sys/arm/conf/BEAGLEBONE Mon Mar 9 15:43:33 2015 (r279814) > @@ -31,7 +31,7 @@ makeoptions WITHOUT_MODULES="ahc" > options KDTRACE_HOOKS # Kernel DTrace hooks > options DDB_CTF # all architectures - kernel ELF linker loads CTF data > makeoptions WITH_CTF=1 > -makeoptions MODULES_OVERRIDE="opensolaris dtrace dtrace/lockstat dtrace/profile dtrace/fbt" > +makeoptions MODULES_EXTRA="opensolaris dtrace dtrace/lockstat dtrace/profile dtrace/fbt" > > options HZ=100 > options SCHED_4BSD # 4BSD scheduler > > Can we not do this, and instead just build all modules? I'm not sure why we eliminate or override modules on some armv6 socs and not on others, but I think it's a concept that's past it's sell-by date now. If there are a few specific modules that aren't good for arm, we should be fixing that in the modules makefiles. I've got some WIP along these lines for beaglebone that's about ready to commit, so I'm asking your opinion, not for you to do all the work. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1425916716.73796.28.camel>