Date: Thu, 12 Apr 2018 10:28:48 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Craig Leres <leres@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r466577 - in head/security/openssh-portable: . files Message-ID: <a0819b0f-a7e3-e402-453e-a458b3812aa3@FreeBSD.org> In-Reply-To: <c6a16f2a-dcc6-7684-c319-c96fb5653ca2@freebsd.org> References: <201804051820.w35IKpi2062956@repo.freebsd.org> <295c901e-d369-fe1b-4f6b-cff59098e166@freebsd.org> <c6a16f2a-dcc6-7684-c319-c96fb5653ca2@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PHfFFIkNvZUT5EaYc9GEmt8jfyvwUFJt1 Content-Type: multipart/mixed; boundary="H3SRhFgXXPctmLtQuiQWGxcn2zsugBIE4"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Craig Leres <leres@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <a0819b0f-a7e3-e402-453e-a458b3812aa3@FreeBSD.org> Subject: Re: svn commit: r466577 - in head/security/openssh-portable: . files References: <201804051820.w35IKpi2062956@repo.freebsd.org> <295c901e-d369-fe1b-4f6b-cff59098e166@freebsd.org> <c6a16f2a-dcc6-7684-c319-c96fb5653ca2@freebsd.org> In-Reply-To: <c6a16f2a-dcc6-7684-c319-c96fb5653ca2@freebsd.org> --H3SRhFgXXPctmLtQuiQWGxcn2zsugBIE4 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Sorry I've been super busy. If this is right please commit it with a PORTREVISION bump. Other patches had similar problems where fuzz applied them incorrectly. On 4/11/2018 9:27 PM, Craig Leres wrote: > On 04/06/18 18:12, Craig Leres wrote: >> This version breaks sshfp support >=20 > I poked at this and the issue is that a block of code that canonicalize= s > the host supplied on the command teleported from main() to > ssh_session2(). What the VerifyHostKeyDNS yes path now encounters is > that the non-canonical version of the hostname is used for the SSHFP > lookup. The base problem is that files/patch-ssh.c has not been updated= > recently and somehow manages to be applied to the wrong part of ssh.c. >=20 > Attached is an updated patch.ssh.c >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Craig --=20 Regards, Bryan Drewery --H3SRhFgXXPctmLtQuiQWGxcn2zsugBIE4-- --PHfFFIkNvZUT5EaYc9GEmt8jfyvwUFJt1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJaz5dWAAoJEDXXcbtuRpfPW0sH/3KBmbrF/x6dHWtAeF5Bov81 WOXXZtWZlax135Aa3KIPc43ApdsCP/H84SD+PEMT55Ky/xP5MQLAfQRZqMTGvJz7 LPCiDk++Ui33aWiT5r6Ah/Nz/+zQGf22MkdRhOdAN5BJvS9ehx8W9O4u5u9nv3s+ My3Mf5T9Y6jemEoVmm/uVAM1olKXkYFBUj37MnA2veR3bCoQ/xOKTJ9v03BZsb22 7sAxG1J74mCOZ3nQPQ/KbCglXK4TOGIcGn6hT/LYyY+Ju0B4IeDra+Bmey8TGMku 7nUNRmigBgWsT5I7/ZCWEKF/bUuWEjqxAMw4HbhMgi2qpe/OmnjxFrrNjF2cY8M= =rvOz -----END PGP SIGNATURE----- --PHfFFIkNvZUT5EaYc9GEmt8jfyvwUFJt1--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a0819b0f-a7e3-e402-453e-a458b3812aa3>