Date: Tue, 3 Apr 2012 08:06:05 -0500 From: Eric van Gyzen <eric@vangyzen.net> To: Rudy <crapsh@monkeybrains.net> Cc: freebsd-current@freebsd.org Subject: Re: ixgbe-2.4.4 compile error Message-ID: <4F7AF5BD.6060409@vangyzen.net> In-Reply-To: <4F7A1913.8040005@monkeybrains.net> References: <4F7A1913.8040005@monkeybrains.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04/02/2012 16:24, Rudy wrote: > > I used the 9.0-RELEASE memstick to install, did a cvsup to STABLE... > > When I downloaded Intel's (Jack's) ixgbe driver, I got an error: > > ixgbe_osdep.h:104: error: conflicting types for 'bool' > @/sys/types.h:271: error: previous declaration of 'bool' was here > > > This patch fixed the 'conflict'. > > diff -u @/sys/types.h.orig @/sys/types.h > --- @/sys/types.h.orig 2012-04-02 14:18:26.000000000 -0700 > +++ @/sys/types.h 2012-04-02 14:20:19.000000000 -0700 > @@ -268,7 +268,7 @@ > #if __STDC_VERSION__ < 199901L && __GNUC__ < 3 && > !defined(__INTEL_COMPILER) > typedef int _Bool; > #endif > -typedef _Bool bool; > +// typedef _Bool bool; > #endif /* !__bool_true_false_are_defined && !__cplusplus */ Perhaps a more appropriate change would be in ixgbe_osdep.h: +#ifndef bool typedef boolean_t bool; +#endif This would change the size of the bool type as used in the ixgbe driver, but after a quick glance through the code, I don't think that would cause any trouble. Try it; if it passes traffic, it's probably correct. Eric
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F7AF5BD.6060409>