Date: Fri, 4 Jan 2008 19:17:28 +0100 From: Joerg Sonnenberger <joerg@britannica.bec.de> To: cvs-src@freebsd.org Subject: Re: cvs commit: src/lib/libarchive archive_endian.h archive_read_support_format_zip.c Message-ID: <20080104181728.GM971@britannica.bec.de> In-Reply-To: <477E71F1.4080301@freebsd.org> References: <200801031830.m03IUb9K049549@repoman.freebsd.org> <477E71F1.4080301@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jan 04, 2008 at 09:50:41AM -0800, Tim Kientzle wrote:
>> +be32dec(const void *pp)
>> +{
>> + unsigned char const *p = (unsigned char const *)pp;
>
> The "const *" is harmless enough, but dropping the
> leading "const" doesn't seem right at all: 'pp'
> is a pointer to const data, 'p' points to
> modifiable data.
This is just reordered. unsigned char const * == const unsigned char *.
Joerg
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080104181728.GM971>