Date: Sat, 4 Mar 2017 18:50:22 +0100 (CET) From: Gerald Pfeifer <gerald@pfeifer.com> To: ports-committers@freebsd.org, Olivier Duchateau <olivierd@FreeBSD.org> Cc: svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r435415 - head/Mk/Uses Message-ID: <alpine.LSU.2.20.1703041840390.2487@anthias.pfeifer.com> In-Reply-To: <201703041553.v24FrGZM044896@repo.freebsd.org> References: <201703041553.v24FrGZM044896@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 4 Mar 2017, Olivier Duchateau wrote:
> Log:
> Fix typos
> Modified: head/Mk/Uses/lxqt.mk
> ==============================================================================
> .for comp in ${_USE_LXQT_ALL}
> . for subcomp in ${${comp}_USE_LXQT_REQ}
> -${comp}_USE_LXQT_REQ+= ${${comp}_USE_LXQR_REQ}
> +${comp}_USE_LXQT_REQ+= ${${subcomp}_USE_LXQT_REQ}
> . endfor
> .endfor
Picking this as just one example, definitely do not want to pick
this commit in particular or you, Olivier!
Let's get better at documenting infrastructure commits (especially).
Sometimes it is important/useful to log at the log, and "fix typo"
(which I've seen a fair bit lately) is not helpful at that. Unless
it's a comment, but even then "Fix typos in comments" or "Fix typos
in description of..." is more useful.
And even when looking at the commit, a bit more guidance what to
look for is helpful.
Gerald (who is guilty of not-too-descriptive commit messages when
it comes to the gcc*-devel ports following snapshots, but
tries hard in other cases)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LSU.2.20.1703041840390.2487>