Date: Sat, 3 Sep 2016 11:42:37 -0700 From: Oleksandr Tymoshenko <gonzo@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r305308 - stable/11/sys/arm/ti Message-ID: <40BCE21A-2FB8-44FD-8C2C-0579D8C0E57F@freebsd.org> In-Reply-To: <20160903084418.GU83214@kib.kiev.ua> References: <201609022204.u82M4KOm025953@repo.freebsd.org> <20160903084418.GU83214@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Sep 3, 2016, at 1:44 AM, Konstantin Belousov <kostikbel@gmail.com> = wrote: >=20 > On Fri, Sep 02, 2016 at 10:04:20PM +0000, Oleksandr Tymoshenko wrote: >> Author: gonzo >> Date: Fri Sep 2 22:04:20 2016 >> New Revision: 305308 >> URL: https://svnweb.freebsd.org/changeset/base/305308 >>=20 >> Log: >> MFC r305039: >>=20 >> Fix TI PRUSS driver panic with INVARIANTS enabled >>=20 >> Value passed as islocked argument to knlist_add should >> be consistent with actual lock state so add lock/unlock >> calls around knlist_add >>=20 >> PR: 212120 >> Submitted by: Manuel Stuhn >>=20 >> Modified: >> stable/11/sys/arm/ti/ti_pruss.c >> Directory Properties: >> stable/11/ (props changed) >>=20 >> Modified: stable/11/sys/arm/ti/ti_pruss.c >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- stable/11/sys/arm/ti/ti_pruss.c Fri Sep 2 21:35:32 2016 = (r305307) >> +++ stable/11/sys/arm/ti/ti_pruss.c Fri Sep 2 22:04:20 2016 = (r305308) >> @@ -310,7 +310,9 @@ ti_pruss_kqfilter(struct cdev *cdev, str >> case EVFILT_READ: >> kn->kn_hook =3D sc; >> kn->kn_fop =3D &ti_pruss_kq_read; >> + mtx_lock(&sc->sc_mtx); >> knlist_add(&sc->sc_selinfo.si_note, kn, 1); >> + mtx_unlock(&sc->sc_mtx); >> break; >> default: >> return (EINVAL); > Wouldn't it be less code to just change the arg to indicate = 'unlocked=E2=80=99 ? It would. I=E2=80=99ll update HEAD and stable/11 soon. Thanks for = spotting.=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?40BCE21A-2FB8-44FD-8C2C-0579D8C0E57F>