Date: Sat, 12 Sep 2015 15:29:45 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Hajimu UMEMOTO <ume@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r396689 - in head/mail: cyrus-imapd23 cyrus-imapd24 cyrus-imapd25 Message-ID: <20150912152945.GA46441@FreeBSD.org> In-Reply-To: <ygey4gbvgp6.wl-ume@FreeBSD.org> References: <201509111758.t8BHwjA5064734@repo.freebsd.org> <ygezj0suf7x.wl-ume@FreeBSD.org> <D8CB01F5D2938F2E37E9593F@atuin.in.mat.cc> <ygey4gbvgp6.wl-ume@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Sep 12, 2015 at 11:46:13PM +0900, Hajimu UMEMOTO wrote: > Then, I'll back them out by myself, sigh. It is hard to inspect > whether it becomes equivalent to the one I intended. You could make > me be disappointed at your effort. Umemoto-san, While those changes do look hard to get/comprehend at the first sight (I had to suffer from similar commits in the past), I don't think there is need for a backout. You might try to back it out piece by piece in your local working copy and review until you have an "aha!" moment and move to the next one. Chances are it's not really that bad after all. The framework got much smarter, people are getting used to it, and old-school code (very nice, perfectly working) will just urge people's itch. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150912152945.GA46441>