Date: Thu, 15 Apr 2021 22:39:51 +0200 From: Mateusz Piotrowski <0mp@FreeBSD.org> To: Guido Falsi <madpilot@FreeBSD.org>, ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: b3c7fff32af0 - main - sysutils/ansible-sshjail: New port Message-ID: <c07b643d-7b32-3d84-facf-04bf122ed1f7@FreeBSD.org> In-Reply-To: <5ce76d1a-ca79-6e84-376b-612805f317b6@FreeBSD.org> References: <202104151800.13FI0R3i033069@gitrepo.freebsd.org> <d7af612e-2b5d-b4b9-f534-bc30e42017b2@FreeBSD.org> <5ce76d1a-ca79-6e84-376b-612805f317b6@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, On 15/04/2021 21:46, Guido Falsi wrote: > On 15/04/21 21:07, Mateusz Piotrowski wrote: >> >>> diff --git a/sysutils/ansible-sshjail/Makefile b/sysutils/ansible-ssh= jail/Makefile >>> new file mode 100644 >>> index 000000000000..73499357b2f0 >>> --- /dev/null >>> +++ b/sysutils/ansible-sshjail/Makefile >>> @@ -0,0 +1,30 @@ >>> +PORTNAME=3D=C2=A0=C2=A0=C2=A0 ansible-sshjail >>> +DISTVERSION=3D=C2=A0=C2=A0=C2=A0 1.1.0-g20210107 >> [snip] >>> +GH_ACCOUNT=3D=C2=A0=C2=A0=C2=A0 austinhyde >>> +GH_TAGNAME=3D=C2=A0=C2=A0=C2=A0 981674f >> Perhaps GH_TAGNAME could be replaced with DISTVERSION* variables based=20 on the output of git=20 >> describe --tags which is "v1.1.0-30-g981674f". >> > > Is there a specific advantage to this approach? > > I did what I've been doing with other ports and also what I see documen= ted in the porter's handbook. > There are a couple of advantages: 1. There is only one block of variables you need to edit in case of an up= date. 2. DISTVERSION=3D1.1.0-30 becomes PORTVERSION=3D1.1.0.30. As a result, yo= u don't have to worry about=20 increasing the date manually. Also, if you happen to update the port twic= e to newer commit on a=20 single day, you don't have to come up with a workaround for 1.1.0-g202101= 07. The DISTVERSION will=20 just naturally increase from 1.1.0-30 to, e.g., 1.1.0-31. In fact, this is described in the FreeBSD Porter's Handbook in Example 5.= 14. Using USE_GITHUB to=20 Access a Commit Between Two Versions. The gYYYYMMDD is reserved for cases=20 when there is no single=20 version tagged by upstream (as explained in Example 5.13. Using USE_GITHU= B When Upstream Does Not=20 Use Versions). Cheers! Mateusz
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c07b643d-7b32-3d84-facf-04bf122ed1f7>