Date: Mon, 18 Nov 2013 07:55:23 -0700 From: Ian Lepore <ian@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, David C Somayajulu <davidcs@FreeBSD.org> Subject: Re: svn commit: r258155 - head/sys/dev/qlxgbe Message-ID: <1384786523.31172.467.camel@revolution.hippie.lan> In-Reply-To: <20131118142226.GA52991@FreeBSD.org> References: <201311150126.rAF1QPZq077225@svn.freebsd.org> <20131118142226.GA52991@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 2013-11-18 at 14:22 +0000, Alexey Dokuchaev wrote: > On Fri, Nov 15, 2013 at 01:26:25AM +0000, David C Somayajulu wrote: > > New Revision: 258155 > > URL: http://svnweb.freebsd.org/changeset/base/258155 > > > > Log: > > ql_hw.[c,h]: set minimum thresholds on pkt size for lro path. > > ql_ioctl.c: validate the length and address of buffer passed to QL_RD_FW_DUMP > > > > Submitted by:David C Somayajulu > > "Submitted by" tag is redundant when submitter == committer. In these > cases, it simply clutters the log rather than adds anything useful. > > ./danfe Not always. I put myself in Submitted By when I'm committing a patch from a PR I filed years ago before I was a committer (sadly there are enough of these that it's not a thing that just happened once). -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1384786523.31172.467.camel>