Date: Sat, 26 May 2018 04:11:27 +0800 From: Marcelo Araujo <araujobsdport@gmail.com> To: Warner Losh <imp@bsdimp.com> Cc: Ed Maste <emaste@freebsd.org>, Marcelo Araujo <araujo@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334199 - head/usr.sbin/bhyve Message-ID: <CAOfEmZiEWLm0ZM8nfT_1rXF%2BiF1=7hAZxMHm5kzAFCjF1F5rVg@mail.gmail.com> In-Reply-To: <CANCZdfq=Qn5X=aRUJpu1UaWdPo-1S88KpO74SvwdMcBL9bvAYw@mail.gmail.com> References: <201805250207.w4P275Pf060725@repo.freebsd.org> <20180525151134.GB99063@spindle.one-eyed-alien.net> <CAOfEmZgV9yssn5v8ZpbkwL=rrifoD1Z=uRxe6a0KyM3mrXrSjQ@mail.gmail.com> <CAF6rxgm32%2B_XazDvbtyFChPigxVB0HQ30r3=CvN65ko=zHq0yA@mail.gmail.com> <CAOfEmZhS4RZPn6%2BqOcU56HUtUgGids79cS=fBKfuGjpBBQQm5g@mail.gmail.com> <20180525174424.GD99063@spindle.one-eyed-alien.net> <CAOfEmZhm3HPGU3r2nK9o3ry8%2BxpzaFRDCgw3qCKgy2CTOu3NaQ@mail.gmail.com> <20180525182139.GE99063@spindle.one-eyed-alien.net> <CAOfEmZiOPsDpzJ1citMhGvVFDFpQg1gY8-tNkj3XReYuFpDC1w@mail.gmail.com> <CAPyFy2DZG7ex1YhjEPZMCkp0FVzGaUGvstgDcb4C-vPi0yM7yA@mail.gmail.com> <CANCZdfq=Qn5X=aRUJpu1UaWdPo-1S88KpO74SvwdMcBL9bvAYw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, May 26, 2018, 4:09 AM Warner Losh <imp@bsdimp.com> wrote: > > > On Fri, May 25, 2018 at 2:02 PM, Ed Maste <emaste@freebsd.org> wrote: > >> On 25 May 2018 at 14:26, Marcelo Araujo <araujobsdport@gmail.com> wrote: >> > >> >> The fact that we don't do NDEBUG builds normally does not allow us to >> >> ignore that it exists. It's perfectly reasonable for a user to build >> >> with CFLAGS+=NDEBUG. That need to work. If code is going to fail to >> >> handle resource errors with NDEBUG set then it needs something like >> this >> >> at the top of the file: >> > >> > Please document it in some place! >> >> NDEBUG is documented in assert(3). The man page should have more of an >> explanation (and examples) of the possible pitfalls of assert() >> though >> > > NDEBUG has been documented in the assert man page since it entered Unix > via PBW in the 7th Edition Unix from Bell Labs. It's part of the C > standard, as well as many POSIX and SVID docs. > Yes I can read that! Now tell me, do we build FreeBSD without assert? If we do, probably we can't run it without crash! > Warner >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfEmZiEWLm0ZM8nfT_1rXF%2BiF1=7hAZxMHm5kzAFCjF1F5rVg>