Date: Sat, 24 Oct 2015 11:10:29 -0400 From: Kris Moore <kris@pcbsd.org> To: Alexey Dokuchaev <danfe@FreeBSD.org>, Kris Moore <kmoore@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r400121 - head/net-im/teamwords Message-ID: <562B9F65.4010603@pcbsd.org> In-Reply-To: <20151024142932.GB69999@FreeBSD.org> References: <201510241406.t9OE6uXi043030@repo.freebsd.org> <20151024142932.GB69999@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/24/2015 10:29, Alexey Dokuchaev wrote: > On Sat, Oct 24, 2015 at 02:06:56PM +0000, Kris Moore wrote: >> New Revision: 400121 >> URL: https://svnweb.freebsd.org/changeset/ports/400121 >> >> [...] >> -.include <bsd.port.options.mk> >> - >> do-install: >> ${STRIP_CMD} ${WRKSRC}/teamwords >> ${INSTALL} ${WRKSRC}/teamwords ${STAGEDIR}${PREFIX}/bin > Wait, what? You strip the binary first and then install it? Why not > use ${INSTALL_PROGRAM} which DTRT itself? > > ./danfe > It's what was suggested when I built the port with DEVELOPER=yes. Is the end-result the same or is this just for the sake of minimalism? That being said, I've changed it now. -- Kris Moore PC-BSD Software / iXsystems Enterprise Storage & Servers Driven By Open Source
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?562B9F65.4010603>