Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 28 Apr 2006 13:36:06 +0200 (CEST)
From:      Michele Possamai <possamai@xs4all.nl>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        possamai@xs4all.nl
Subject:   ports/96460: Made tkinter dependency optional.(patch included)
Message-ID:  <200604281136.k3SBa68Y006449@zaadje.nl>
Resent-Message-ID: <200604281140.k3SBeIck043171@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         96460
>Category:       ports
>Synopsis:       Made tkinter dependency optional.(patch included)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Apr 28 11:40:17 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Michele Possamai
>Release:        FreeBSD 5.5-PRERELEASE i386
>Organization:
>Environment:
System: FreeBSD zaadje.nl 5.5-PRERELEASE FreeBSD 5.5-PRERELEASE #0: Wed Apr 19 16:46:55 CEST 2006 root@zaadje.nl:/usr/obj/usr/src/sys/SCORPIO i386


	
>Description:
At this moment the py-imaging port installs py-tkinter as a dependency.
This is not a necessary dependency, it only is if you want to use it in X.
For people that don't want to have X installed tkinter is completely useless
and unnecessary and because of that I'd like to see it being optional.

A Makefile patch is provided in unified diff format.
>How-To-Repeat:
	
>Fix:

	

--- py-imaging.patch begins here ---
diff -ruN py-imaging.old/Makefile py-imaging/Makefile
--- py-imaging.old/Makefile	Thu Jun 16 23:50:23 2005
+++ py-imaging/Makefile	Fri Apr 28 13:13:49 2006
@@ -10,16 +10,14 @@
 CATEGORIES=	graphics python
 MASTER_SITES=	http://effbot.org/downloads/ \
 	        http://www.pythonware.net/storage/
-PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
+PKGNAMEPREFIX=	py-
 DISTNAME=	Imaging-${PORTVERSION}
 
 MAINTAINER=	mainland@apeiron.net
 COMMENT=	The Python Imaging Library
 
-BUILD_DEPENDS=	${PYTHON_SITELIBDIR}/_tkinter.so:${PORTSDIR}/x11-toolkits/py-tkinter
 LIB_DEPENDS=	jpeg.9:${PORTSDIR}/graphics/jpeg \
 		freetype.9:${PORTSDIR}/print/freetype2
-RUN_DEPENDS=	${PYTHON_SITELIBDIR}/_tkinter.so:${PORTSDIR}/x11-toolkits/py-tkinter
 
 DIST_SUBDIR=	 python
 USE_PYTHON=	 yes
@@ -28,7 +26,14 @@
 DOCDIRS=		${PREFIX}/share/doc/py-imaging
 EXAMPLESDIR=	${PREFIX}/share/examples/py-imaging
 
+OPTIONS=	TKINTER "Build with tkinter for X support" off
+
 .include <bsd.port.pre.mk>
+
+.if !defined(WITHOUT_TKINTER)
+   BUILD_DEPENDS+=	${PYTHON_SITELIBDIR}/_tkinter.so:${PORTSDIR}/x11-toolkits/py-tkinter
+   RUN_DEPENDS+=	${PYTHON_SITELIBDIR}/_tkinter.so:${PORTSDIR}/x11-toolkits/py-tkinter
+.endif
 
 post-install:
 .for file in ImPlatform.h Imaging.h
--- py-imaging.patch ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200604281136.k3SBa68Y006449>