Date: Sun, 1 Sep 2013 16:13:13 -0700 From: Mike Harding <mvharding@gmail.com> To: Adrian Chadd <adrian@freebsd.org> Cc: "freebsd-acpi@freebsd.org" <freebsd-acpi@freebsd.org>, FreeBSD Stable Mailing List <freebsd-stable@freebsd.org>, Andriy Gapon <avg@freebsd.org> Subject: Re: 9.2-RC3 - suspend/resume causes slow system performance Message-ID: <CALRn2n-7e4pvto-7jeYKL-CMgDNmCWJM=vq4vyo9ZV1QRdgTpA@mail.gmail.com> In-Reply-To: <CAJ-Vmo=%2BWPXLDCpMu-i1MrjEtn4mA04kDx96C2t0-xPvC-cP9w@mail.gmail.com> References: <CALRn2n_2tUc0vPCFpgmAjYRm1=7KB5sA3A%2BxQqcc=ye-S1-0LA@mail.gmail.com> <CAJ-Vmom970ZBLPLWWTomkKtX1w-Fi3cj5qva1_ODcx22nqEXfA@mail.gmail.com> <CALRn2n9G1%2BBS8KVUc_RFZj-snM3FVJvsEEcnWqv-GF82=CqS6Q@mail.gmail.com> <CAJ-VmomWMhQNU1w0eWdwrKYz2fuZ5xZimgxQWUEkPqaQcgYkjw@mail.gmail.com> <CALRn2n_e2Uu4Y2aHUSP=6_aQDPeCk_OkrCxiFWaD0BxmbgP4-A@mail.gmail.com> <CAJ-VmokesYVnYJUnNgULKwL-wqb_-SqqYi=3KUSCGbHNVgOOUw@mail.gmail.com> <5222E19C.9040402@FreeBSD.org> <CAJ-VmokHyXaxZTb-3Bpp19Go%2BsW=ms0Zh0WAMB7sD1JSX6HdUw@mail.gmail.com> <5223B313.9060708@FreeBSD.org> <CAJ-VmomweLyjXnBHjp=Nrs3P4n7UNF1bCV_N41RYJQqGLpg9hQ@mail.gmail.com> <5223B9C3.2070508@FreeBSD.org> <CAJ-Vmo=%2BWPXLDCpMu-i1MrjEtn4mA04kDx96C2t0-xPvC-cP9w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This would be a 'strange story' if I had not tracked this down. The disk
works, only much slower
than normal. I only noticed it because I was doing a buildworld. There is
no crash, no dmesg,
no console logs.
I'll ask again, why change that line? Did you feel that the original
author of the code had made a
mistake? The code in question is from Oct. 2005. Also why move the check
for the HT in front
of the check for the disabled idle?
The only change that affects my system is that idle is enabled in a code
path that should only
be run when idle is disabled. I don't know the larger context but I also
don't know why the code
was changed. It looks like the intent of the code has been changed ("don't
suspend if this
flag is set") and I don't know what benefit this provides. The code path
seems to only be
run during startup, shutdown and wake from sleep.
Contact me via email and I'll set up remote access. This is a personal
machine so this is a bit
awkward.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALRn2n-7e4pvto-7jeYKL-CMgDNmCWJM=vq4vyo9ZV1QRdgTpA>