Date: Mon, 21 Apr 2014 09:17:17 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Adam Weinberger <adamw@adamw.org> Subject: Re: Commit logs for 2014/04/11 Message-ID: <a82341408659ba89a28670ae8d5a3de4@shatow.net> In-Reply-To: <20140421100736.GA96588@FreeBSD.org> References: <20140412035900.3C695121E45@apnoea.adamw.org> <EA3162FC-904F-4209-81D8-67CDADA357A2@adamw.org> <20140420092922.GA90642@FreeBSD.org> <C7FCE6B1-776A-478D-B066-990E1478893E@FreeBSD.org> <20140421100736.GA96588@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2014-04-21 05:07, Alexey Dokuchaev wrote: > On Sun, Apr 20, 2014 at 02:35:25PM -0500, Bryan Drewery wrote: >> > On Apr 20, 2014, at 4:29, Alexey Dokuchaev <danfe@FreeBSD.org> wrote: >> >> On Sat, Apr 12, 2014 at 10:11:44AM -0400, Adam Weinberger wrote: >> >> * Please, please don't mandate .sample. Plenty of of ports install >> > >> > Actually, it's not really ".sample". It's any six-letter word if I read the >> > code correctly. >> >> No. It is literally only .sample. > > Right; I forgot to check the other file, sample.yaml. > >> >> sample conf files with different extension. "-dist" is very common >> >> for php ports, for example. Let @sample take two arguments. Like >> >> @sample etc/pants.conf-dist pants.conf >> > >> > Why do we need the second argument? Can't we just use the rightmost >> > extension? Proof of concept attached. >> >> I would think you would support consistency :) > > Well, at first it seemed like a nice idea that could be implemented > without > sacrificing much consistency. After received feedback, I'm no longer > sure > about it, so I guess I'm fine with ".sample", at least for the time > being. > > ./danfe It's a tough decision. It's not exactly simple to support an arbitrary extension. Pkg does not support arguments for Keywords. Some extensions are -dist. Which should have precedence over a file having both '.' and '-'? What if they have neither? My original PoC had support for -dist and .sample, but discussing with bapt we decided on making an implicit policy of files being installed as .sample. It's nicer for users if all sample/dist/original files are named the same. I'm still in favor of supporting '-dist' as well. -- Regards, Bryan Drewery
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a82341408659ba89a28670ae8d5a3de4>