Date: Wed, 28 Jan 2015 19:13:26 +0000 From: "rrs (Randall Stewart)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: <eda05d64b4324a5f1c97a26f4fbd46e1@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-vhk6ww63dvpj6egspuyt-req@FreeBSD.org> References: <differential-rev-PHID-DREV-vhk6ww63dvpj6egspuyt-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
rrs added a comment. Moving the tests to a sub-dir sounds like a good idea as well.. Thanks Hans.. INLINE COMMENTS sys/kern/kern_timeout.c:674 Hans, no *you must* set it to false here in the soft clock so you can recognize if it is requested to be stopped (if possible). The return codes are all correct if the c_lock is set or not. sys/kern/kern_timeout.c:1059 Sure I can do that.. I will ALT-Q it and see if I can get it better formatted sys/modules/callout_test/callout_test.c:58 Sure thats a good ideas since they are only used in the module. sys/modules/callout_test/callout_test.c:69 ahh yes, it surely is. I had been testing it in a branch that did not have the define in callout.h and it must have slipped in.. good catch! sys/modules/callout_test/callout_test.c:254 Yes it is, since the MOD_QUIESCE may unload the model.. or it may not. sys/sys/callout_test.h:1 Good catch I will fix it ;-) sys/sys/kern_testfrwk.h:43 That sounds fine.. I was just copying how the callout code did it (which was without typedef) but we can do that too ;-) REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, imp, adrian, sbruno, lstewart, hselasky Cc: neel, erj, freebsd-net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?eda05d64b4324a5f1c97a26f4fbd46e1>