Date: Sat, 29 Jun 2019 09:58:16 -0500 From: Santhosh Raju <santhosh.raju@gmail.com> To: Jan Beich <jbeich@freebsd.org> Cc: Philip Paeps <philip@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r504812 - in head/www/cliqz: . files Message-ID: <CACQjD2HKpXseKii9imdoUjSY%2BGc%2BnA99%2BrCJpg_11113FozdRg@mail.gmail.com> In-Reply-To: <r27m-oc49-wny@FreeBSD.org> References: <201906212010.x5LKAa6J067592@repo.freebsd.org> <r27m-oc49-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Apologies for the delayed reply, I was caught up in a busy week, my replies are in-line. On Fri, Jun 21, 2019 at 4:35 PM Jan Beich <jbeich@freebsd.org> wrote: > > Philip Paeps <philip@FreeBSD.org> writes: > > > Author: philip > > Date: Fri Jun 21 20:10:36 2019 > > New Revision: 504812 > > URL: https://svnweb.freebsd.org/changeset/ports/504812 > > > > Log: > > www/cliqz: update to 1.27.3 > > > > PR: 238410 > > Submitted by: Santhosh Raju <santhosh.raju@gmail.com> (maintainer) > [...] > > MAKE_ENV+= LLVM_CONFIG=llvm-config${LLVM_DEFAULT} > > +MAKE_ENV+= LLVM_OBJDUMP=${LOCALBASE}/llvm${LLVM_DEFAULT}/bin/llvm-objdump > > Both LLVM_CONFIG and LLVM_OBJDUMP can be dropped in favor of CC/CXX e.g., > > MAKE_ENV+= CC=clang${LLVM_DEFAULT} CXX=clang++${LLVM_DEFAULT} > I tried making this change in www/cliqz but it would not pick up the LLVM_CONFIG Looking at Mk/bsd.gecko.mk I do see that there is a variable exported MOZ_EXPORT+= LLVM_CONFIG=llvm-config${LLVM_DEFAULT} which does similar functionality to www/cliqz (since cliqz is also Firefox based). > as LLVM_CONFIG will be replaced by --with-libclang-path in future, > see https://bugzilla.mozilla.org/show_bug.cgi?id=1526857 I looked around with the above flag, but was not able to successfully set it for making www/cliqz compile. I also tried setting the CC / CXX outside of the MAKE_ENV, and was met with the same issue, each time in the configure phase it would fail to find the LLVM configuration. Let me know if I am doing something wrong from my end. As of now I shall submit the cliqz-1.27.4 patch without these improvements. Regards Santhosh
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACQjD2HKpXseKii9imdoUjSY%2BGc%2BnA99%2BrCJpg_11113FozdRg>