Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 4 Feb 2011 00:53:07 +0100
From:      Joachim Tingvold <joachim@tingvold.com>
To:        Kenneth D. Merry <ken@freebsd.org>
Cc:        freebsd-scsi@freebsd.org, Alexander Motin <mav@freebsd.org>
Subject:   Re: mps0-troubles
Message-ID:  <EF8D9C50-B601-4A16-8CB3-DF958EBE6AB9@tingvold.com>
In-Reply-To: <20110203221056.GA25389@nargothrond.kdm.org>
References:  <B2CFC8A1-FA1D-4718-99C3-AC3430A905C2@tingvold.com> <41C64262-4300-4187-B5FD-04A5EFB7F87C@tingvold.com> <20110113203750.GA39494@nargothrond.kdm.org> <B22C5568-24D0-4530-B90A-BA6A6CAF111C@tingvold.com> <20110114001758.GA12793@nargothrond.kdm.org> <D24332F3-56AF-484C-9592-1097BF684E37@tingvold.com> <07392102-4584-4690-9188-5202728CC7CA@tingvold.com> <20110120155746.GA22515@nargothrond.kdm.org> <BC40CE83-6116-49CD-8D37-5BC29893449D@tingvold.com> <070C12D5-A54F-4A48-A151-EBA16EF32A13@tingvold.com> <20110203221056.GA25389@nargothrond.kdm.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 03, 2011, at 23:10:56PM GMT+01:00, Kenneth D. Merry wrote:
> I've attached a patch that has a number of debugging sysctls, a  
> change from
> gibbs@ that has to do with device removal, and some other extra  
> debugging
> cruft.  (i.e. this patch won't go into the tree as-is, it's just for
> debugging.)

	Index: mps.c
	|===================================================================
	|--- mps.c	(revision 218241)
	|+++ mps.c	(working copy)
	--------------------------
	Patching file mps.c using Plan A...
	Hunk #1 succeeded at 386 (offset -1 lines).
	Hunk #2 succeeded at 734 (offset -7 lines).
	Hunk #3 succeeded at 812 (offset -9 lines).
	Hunk #4 failed at 847.

The patch is looking for

	SYSCTL_ADD_UINT(&sc->sysctl_ctx, SYSCTL_CHILDREN(sc->sysctl_tree),  
[...]
	SYSCTL_ADD_UINT(&sc->sysctl_ctx, SYSCTL_CHILDREN(sc->sysctl_tree),  
[...]

but my mps.c has

	SYSCTL_ADD_INT(&sc->sysctl_ctx, SYSCTL_CHILDREN(sc->sysctl_tree), [...]
	SYSCTL_ADD_INT(&sc->sysctl_ctx, SYSCTL_CHILDREN(sc->sysctl_tree), [...]

That, and all the offsets; maybe my mps-driver is a bit outdated?  
Maybe this is a stupid question, but I'm no FreeBSD-expert. (-:

-- 
Joachim



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EF8D9C50-B601-4A16-8CB3-DF958EBE6AB9>