Date: Mon, 27 Oct 2014 11:08:58 -0600 From: Ian Lepore <ian@FreeBSD.org> To: Kurt Jaeger <pi@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Bruce Evans <brde@optusnet.com.au> Subject: Re: svn commit: r273734 - head/bin/dd Message-ID: <1414429738.17308.9.camel@revolution.hippie.lan> In-Reply-To: <20141027162034.GN1492@f10.opsec.eu> References: <201410271138.s9RBcHrA002447@svn.freebsd.org> <20141028005225.S2013@besplex.bde.org> <20141027162034.GN1492@f10.opsec.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 2014-10-27 at 17:20 +0100, Kurt Jaeger wrote: > Hi! > > > > Log: > > > bin/dd: Fix incorrect casting of arguments > [...] > > Both of these work correctly in my version (with a relatively small patch > > and no breakage of other cases). (I actually typed large values as -1 > > and 11111111111111111111111111. -1 means (uintmax_t)-1 although this > > is undocumented and now broken). > > So, given this detailed review, should I revert the change ? > Given that it breaks the build for 32 bit architectures, it probably should be reverted until a different set of changes is available. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1414429738.17308.9.camel>