Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 14 Jul 2018 07:24:10 -0700
From:      Sean Chittenden <seanc@FreeBSD.org>
To:        Mathieu Arnold <mat@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r473756 - head/security/teleport
Message-ID:  <20180714142410.mdn7rwphwveeojml@FreeBSD.org>
In-Reply-To: <20180702192120.bmrv74c4atutx26b@atuin.in.mat.cc>
References:  <201807021659.w62GxDgI031531@repo.freebsd.org> <20180702192120.bmrv74c4atutx26b@atuin.in.mat.cc>

next in thread | previous in thread | raw e-mail | index | archive | help

--aijyojrnkjwo542o
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> > Modified: head/security/teleport/Makefile
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > --- head/security/teleport/Makefile	Mon Jul  2 16:45:53 2018	(r473755)
> > +++ head/security/teleport/Makefile	Mon Jul  2 16:59:13 2018	(r473756)
> > @@ -45,9 +45,9 @@ post-extract:
> >  post-patch:
> >  	@${REINPLACE_CMD} -e 's|^GITREF=3D.*|GITREF=3D${GH_TAG_COMMIT}|' \
> >  		${WRKDIR}/${GO_TELEPORT_SRC_DIR}/version.mk
> > -	@${FIND} ${WRKDIR} -type f \
> > -		-exec ${SED} -i '' -e 's|\/var\/lib|/var/db|g' {} \; \
> > -		-exec ${SED} -i '' -e 's|\/usr\/bin\/hostname|/bin/hostname|g' {} \;
> > +	@${FIND} ${WRKDIR} -type f -exec ${SED} -i '' \
> > +		-e 's|\/var\/lib|/var/db|g' \
> > +		-e 's|\/usr\/bin\/hostname|/bin/hostname|g' {} \;
>=20
> Now, you are only running one sed for each file in WRKDIR instead of two.
> Let's cut that down to only one sed call for all the files, please replace
> "\;" with "+".

[ Sorry, I've been traveling for the last week and unable to dig into this =
or test ]

Huh, I didn't know find(1) had an `-exec +` mode, and yes, that's the right=
 way
to update the ports.  TIL.  Thanks!  -sc

--=20
Sean Chittenden

--aijyojrnkjwo542o
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGTBAEBCgB9FiEE74y44SUGZ4YNR0/x11Nmqtx5Ry0FAltKB4lfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVG
OENCOEUxMjUwNjY3ODYwRDQ3NEZGMUQ3NTM2NkFBREM3OTQ3MkQACgkQ11Nmqtx5
Ry1Cvgf+Md7144IxfQ/CPbOjA7af76CbS4rdR2HiLw/ml4Prw4xmvLUVa6O2k/ir
T+ryWjBUkXT9XTtj5XNAnyPIqEBPmWGWy+LS/X64Vy7AUHkysao+IznjYCT2p0/R
CiglaSXaEq76zInHRph/xzN/WgV9WsdShY+Zzmbz7KcZxseo/9LE73RqxBtd30AM
L7XAAC0yrl94h/c+/PcZHRxe7/71oAmAYM2H6VEH1IH+WcXuMO+k8q4gGQ+wmRQw
oyWXPTw+4ShKESDKc98ZegTDdqjJSP1F7/4LGZSdcXzVLS9c8SBvHDtGi4G7cIQ4
ByjTTpJ7/TTa1/s+avkm5uQMI8Artw==
=qDfV
-----END PGP SIGNATURE-----

--aijyojrnkjwo542o--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180714142410.mdn7rwphwveeojml>