Date: Tue, 19 Jul 2011 08:45:00 -0500 From: Stephen Montgomery-Smith <stephen@missouri.edu> To: Doug Barton <dougb@FreeBSD.org> Cc: "vanhu@netasq.com" <vanhu@netasq.com>, Stephen Montgomery-Smith <stephen@FreeBSD.org>, "cvs-all@FreeBSD.org" <cvs-all@FreeBSD.org>, John Hein <jhein@symmetricom.com>, "maho@FreeBSD.org" <maho@FreeBSD.org>, "cvs-ports@FreeBSD.org" <cvs-ports@FreeBSD.org>, "ports-committers@FreeBSD.org" <ports-committers@FreeBSD.org> Subject: Re: cvs commit: ports/security/ipsec-tools Makefile ports/security/ipsec-tools/files racoon.sh.in Message-ID: <4E258A5C.5040903@missouri.edu> In-Reply-To: <4E2542BA.5040203@FreeBSD.org> References: <201107190333.p6J3XQVD050847@repoman.freebsd.org> <4E2542BA.5040203@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07/19/2011 03:39 AM, Doug Barton wrote: > This change is an improvement, but it doesn't go far enough in a couple > of directions. The 2 most important being that faststart is not the only > possible prefix there, and we don't want that block to run > unconditionally in any case. > > I've attached the full script I'm suggesting because the diff doesn't > make much sense. One thing I didn't change because I'm not sure if it > needs to be run early is changing the current require/before to just > REQUIRE: LOGIN, which is what we prefer ports scripts to do. However if > there is a good reason for this one to run earlier, that's fine. > > If you have any questions, let me know. > > > Doug > I'll wait for confirmation from the port maintainer, but it would be good to get John Hein's opinion as well. Thanks, Stephen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E258A5C.5040903>