Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 19 Nov 2009 16:47:59 -0600
From:      Nathan Whitehorn <nwhitehorn@freebsd.org>
To:        Hans Petter Selasky <hselasky@FreeBSD.org>
Cc:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   Re: PERFORCE change 170842 for review
Message-ID:  <4B05CB1F.8020100@freebsd.org>
In-Reply-To: <200911192235.nAJMZ2XH072195@repoman.freebsd.org>
References:  <200911192235.nAJMZ2XH072195@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hans Petter Selasky wrote:
> http://p4web.freebsd.org/chv.cgi?CH=170842
>
> Change 170842 by hselasky@hselasky_laptop001 on 2009/11/19 22:34:49
>
> 	
> 	USB input:
> 		 - ATP patch from Rohit Grover:
> 		   - fixes some minor issues and
> 		     makes the control transfer
> 		     fully asynchronous
>
>
>   
[...]
> @@ -1530,7 +1574,7 @@
>  		return (ENXIO);
>  
>  	if (usbd_lookup_id_by_uaa(atp_devs, sizeof(atp_devs), uaa) == 0)
> -		return BUS_PROBE_SPECIFIC;
> +		return 0;
>  	else
>  		return ENXIO;
>  }
Why are you replacing symbolic constants with less informative numeric ones?
-Nathan



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B05CB1F.8020100>