Date: Thu, 19 May 2016 21:31:47 -0700 From: Ravi Pokala <rpokala@mac.com> To: Jason Harmening <jason.harmening@gmail.com>, "Jason A. Harmening" <jah@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r300258 - head/sys/dev/iicbus Message-ID: <AAABD345-C906-4203-8465-94B3D7519ABB@panasas.com> In-Reply-To: <573E8CFB.8090007@gmail.com> References: <201605200303.u4K334pG019632@repo.freebsd.org> <371B94E2-E906-4F9C-9A9B-A9D35CD93D21@panasas.com> <573E8CFB.8090007@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
-----Original Message----- From: Jason Harmening <jason.harmening@gmail.com> Date: 2016-05-19, Thursday at 21:05 To: Ravi Pokala <rpokala@mac.com>, "Jason A. Harmening" <jah@FreeBSD.org>, = <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freeb= sd.org> Subject: Re: svn commit: r300258 - head/sys/dev/iicbus >On 05/19/16 20:50, Ravi Pokala wrote: >> -----Original Message----- >> From: <owner-src-committers@freebsd.org> on behalf of "Jason A. Harmenin= g" <jah@FreeBSD.org> >> Date: 2016-05-19, Thursday at 20:03 >> To: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-he= ad@freebsd.org> >> Subject: svn commit: r300258 - head/sys/dev/iicbus >>=20 >> Hi Jason, >>=20 >> If I=E2=80=99m reading that right, it=E2=80=99s not preventing any allocations, but = it is preventing a leak. Is that correct? >>=20 >> Thanks, >>=20 >> Ravi (rpokala@) > >Hi Ravi, > >There shouldn't be a leak in here, but checking the result prevents >falling through the rest of the function, including the unnecessary >malloc of usrbufs right after this. How did I miss that earlier? Time for new glasses! :-P >It also makes the error handling clearer. Yeah. >Thanks, >Jason Thank *you*, Ravi (rpokala@)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AAABD345-C906-4203-8465-94B3D7519ABB>