Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 30 Oct 2013 10:04:35 -0700
From:      Cy Schubert <Cy.Schubert@komquats.com>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Cy Schubert <cy@FreeBSD.org>
Subject:   Re: svn commit: r332109 - in head/net/vnc: . files
Message-ID:  <201310301704.r9UH4ZQk005266@slippy.cwsent.com>
In-Reply-To: Message from Alexey Dokuchaev <danfe@FreeBSD.org> of "Wed, 30 Oct 2013 14:35:59 -0000." <20131030143559.GA34668@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
In message <20131030143559.GA34668@FreeBSD.org>, Alexey Dokuchaev writes:
> On Wed, Oct 30, 2013 at 01:52:16PM +0000, Cy Schubert wrote:
> > New Revision: 332109
> > URL: http://svnweb.freebsd.org/changeset/ports/332109
> > 
> > Log:
> >   Fix under 10-STABLE and 11-CURRENT.
> > 
> > +.if ${OSVERSION} > 1000000
> 
> OSVERSION seems inaccurate, should probably be 1000054.
> 
> > +USE_GCC=	4.6+
> 
> Gerald will bite you for this. :)
> 
> > +.if ${OSVERSION} > 1000000
> 
> Ditto.
> 
> > +	cd ${WRKSRC}/xc && ${MAKE_ENV} make CC=${CC} CXX=${CXX} ${MAKE_ARGS} Wo
> rld
> > +.else
> >  	cd ${WRKSRC}/xc && make CC=${CC} CXX=${CXX} World
> >  .endif
> > +.endif
> 
> Ideally, the code should be fixed in a way that it would be built again with
> any compiler, and all hacks from Makefile removed.

The C and C++ code builds with clang. Imake on the other hand has a problem 
with clang's cpp. The problem is that the clang cpp re-evaluates 
expressions whereas the GNU cpp does not. Can this be fixed? Possibly with 
a lot of work but a better solution would be to have cpp behave as it did 
before.


-- 
Cheers,
Cy Schubert <Cy.Schubert@komquats.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.






Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201310301704.r9UH4ZQk005266>