Date: Tue, 2 Oct 2001 11:49:36 +0300 From: Ruslan Ermilov <ru@FreeBSD.ORG> To: Mark Murray <mark@grondar.za> Cc: arch@FreeBSD.ORG Subject: Re: [Patch] style.9 nit Message-ID: <20011002114936.L74839@sunbay.com> In-Reply-To: <200110011648.f91Gmgt25779@grimreaper.grondar.za>; from mark@grondar.za on Mon, Oct 01, 2001 at 05:48:42PM %2B0100 References: <200110011648.f91Gmgt25779@grimreaper.grondar.za>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 01, 2001 at 05:48:42PM +0100, Mark Murray wrote: > Hi > > Any objections to this patch? > > It removes argument names from an example function prototype > to match a previously mentioned guideline about such names. > > eg: > > int foo(int bar); > > becomes > > int foo(int); > Hmm, what's wrong with this? : In header files visible to userland applications, prototypes that are : visible must use either protected names or no names with the types. It : is preferable to use protected names. E.g., use: : : void function(int); : : or: : : void function(int _fd); Your diff actually changes: int foo(int _bar); to int foo(int); which is acceptable prototype with "protected" names. Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011002114936.L74839>